Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/adaptiveproperties #129

Closed
wants to merge 3 commits into from
Closed

Conversation

E-vaTRON
Copy link
Collaborator

@E-vaTRON E-vaTRON commented Apr 4, 2023

COOL NEW PAGE !!!!

Page name: Adaptive Properties Page

Contributors

Describe your changes

Have we discussed about this before ? (Please link the discussion link below)

Added AdaptiveProperties page requirements as following:

  • AdaptivePropertiesPage.xaml
    • Change the x:Class to project namespace standard (ex: x:Class="MAUIsland.LabelPage")?
    • Include xmlns:app="clr-namespace:MAUIsland"
    • Change ContentPage to app:BasePage
    • Hook the x:DataType to the AdaptivePropertiesViewModel
    • Provide Padding="10" to app:BasePage
    • Provide ControlInfo to app:BasePage.Resources
    • Provide PropertiesListHeader to app:BasePage.Resources
    • Provide PropertiesListFooter to app:BasePage.Resources
    • Provide PropertyItemsSource to app:BasePage.Resources
    • Provide a brief Control Info UI ?
         <Frame Style="{x:StaticResource DocumentContentFrameStyle}">
                  <Label Text="{x:StaticResource ControlInfo}" />
         </Frame>
      • Provide Properties List UI
         <Frame Style="{x:StaticResource DocumentContentFrameStyle}">
                  <CollectionView
                      Footer="{x:StaticResource PropertiesListFooter}"
                      Header="{x:StaticResource PropertiesListHeader}"
                      ItemsSource="{x:StaticResource PropertyItemsSource}"
                      Style="{x:StaticResource PropertiesListStyle}" />
         </Frame>
  • AdaptivePropertiesPage.xaml.cs
    • Did you change the namespace to project namespace standard namespace MAUIsland?
    • Did you remove inheritance ContentPage?
    • Did you organize everything inside region?
    • Did you change <Page>ViewModel into the constructor parmeter?
    • Did you hook the page binding context to the page view model - BindingContext = vm; ?
  • AdaptivePropertiesPageViewModel.cs
    • Did you inherit the NavigationAwareBaseViewModel?
    • Did you organize everything inside region?
    • Did you modify the constructor like the example we provide?
      #region [CTor]
      public LabelPageViewModel(IAppNavigator appNavigator)
                                      : base(appNavigator)
      {
      
      }
      #endregion

Register AdaptiveProperties page route requirements as following:

  • Did you create now route constant ?
  • Did you register page route in AppShell.xaml.cs ?
  • If the page is one of applciation root route did you register it to AppShell.xaml ?

Register AdaptiveProperties page services:

  • Did you register the page with the view model in RegisterPages ?
  • Did you register all the created services RegisterServices ?

@E-vaTRON E-vaTRON requested a review from Strypper April 4, 2023 11:06
@E-vaTRON E-vaTRON linked an issue Apr 4, 2023 that may be closed by this pull request
@Strypper Strypper added on-hold 💤 Blocked !!!! new feature 🚀 New feature addition level/we-are-fucked 💀 Well shit !!!!! labels Apr 15, 2023
@Strypper Strypper removed their request for review June 23, 2023 04:10
@Strypper Strypper closed this Jun 29, 2023
@Strypper Strypper deleted the 118-rnd-adaptive-propertiesmaui branch July 5, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/we-are-fucked 💀 Well shit !!!!! new feature 🚀 New feature addition on-hold 💤 Blocked !!!!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[RnD]: Adaptive-Properties.MAUI
3 participants