Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘· Sonar Cloud μΆ”κ°€ #6

Merged
merged 1 commit into from
Sep 8, 2024
Merged

πŸ‘· Sonar Cloud μΆ”κ°€ #6

merged 1 commit into from
Sep 8, 2024

Conversation

waterfogSW
Copy link
Member

@waterfogSW waterfogSW commented Sep 8, 2024

Summary by CodeRabbit

  • New Features

    • GitHub Actions μ›Œν¬ν”Œλ‘œμš° "Test and Analyze" μΆ”κ°€: μ½”λ“œ λ³€κ²½ μ‹œ μžλ™μœΌλ‘œ ν…ŒμŠ€νŠΈ 및 정적 뢄석 μˆ˜ν–‰.
    • JaCoCo μ½”λ“œ 컀버리지 도ꡬλ₯Ό μœ„ν•œ μƒˆλ‘œμš΄ λͺ¨λ“ˆ :support:jacoco μΆ”κ°€.
  • Bug Fixes

    • μ„œλΈŒν”„λ‘œμ νŠΈ 컀밋 μ‹λ³„μž μ—…λ°μ΄νŠΈ: μ˜μ‘΄μ„±, κΈ°λŠ₯ λ˜λŠ” 버그 μˆ˜μ • 반영.
  • Documentation

    • SonarQube 뢄석을 μœ„ν•œ μƒˆλ‘œμš΄ μ„€μ • μΆ”κ°€: ν”„λ‘œμ νŠΈ ν‚€, 쑰직, 호슀트 URL 및 컀버리지 λ³΄κ³ μ„œ 경둜 μ •μ˜.

@waterfogSW waterfogSW self-assigned this Sep 8, 2024
Copy link

coderabbitai bot commented Sep 8, 2024

Walkthrough

이 λ³€κ²½ 사항은 GitHub Actions μ›Œν¬ν”Œλ‘œμš° "Test and Analyze"λ₯Ό μΆ”κ°€ν•˜μ—¬ ν”„λ‘œμ νŠΈμ˜ ν…ŒμŠ€νŠΈ 및 정적 뢄석을 μžλ™ν™”ν•©λ‹ˆλ‹€. λ˜ν•œ, SonarQube와 JaCoCoλ₯Ό ν†΅ν•©ν•˜μ—¬ μ½”λ“œ ν’ˆμ§ˆ 뢄석 및 컀버리지 보고λ₯Ό μœ„ν•œ μƒˆλ‘œμš΄ ꡬ성 μš”μ†Œλ₯Ό μ„€μ •ν•©λ‹ˆλ‹€. λ§ˆμ§€λ§‰μœΌλ‘œ, settings.gradle.kts νŒŒμΌμ— μƒˆλ‘œμš΄ λͺ¨λ“ˆ :support:jacocoλ₯Ό μΆ”κ°€ν•˜μ—¬ μ½”λ“œ 컀버리지 κΈ°λŠ₯을 κ°•ν™”ν•©λ‹ˆλ‹€.

Changes

파일 λ³€κ²½ μš”μ•½
.github/workflows/test_analyze.yaml μƒˆλ‘œμš΄ GitHub Actions μ›Œν¬ν”Œλ‘œμš° μΆ”κ°€ 및 ν…ŒμŠ€νŠΈ, 정적 뢄석 μ„€μ •
build.gradle.kts SonarQube ꡬ성 μΆ”κ°€ 및 JaCoCo 컀버리지 보고 μ„€μ •
settings.gradle.kts :support:jacoco λͺ¨λ“ˆ μΆ”κ°€
openapi ν•˜μœ„ ν”„λ‘œμ νŠΈ 컀밋 μ‹λ³„μž λ³€κ²½

Poem

🐰 λ³€ν™”μ˜ λ°”λžŒμ΄ λΆˆμ–΄μ™€
ν…ŒμŠ€νŠΈμ™€ 뢄석이 ν•¨κ»˜ν•΄
μ½”λ“œμ˜ ν’ˆμ§ˆ, 높아지리라
컀버리지 보고, μƒˆλ‘œμ΄ μ—΄λ €
즐거운 개발, ν•¨κ»˜ λ›°μ–΄λ³΄μž!
πŸ₯•βœ¨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarcloud bot commented Sep 8, 2024

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between acce6b7 and 8d492a4.

Files selected for processing (4)
  • .github/workflows/test_analyze.yaml (1 hunks)
  • build.gradle.kts (1 hunks)
  • openapi (1 hunks)
  • settings.gradle.kts (1 hunks)
Files skipped from review due to trivial changes (1)
  • openapi
Additional comments not posted (6)
settings.gradle.kts (2)

10-10: λͺ¨λ“ˆ μΆ”κ°€ 승인됨

:support:jacoco λͺ¨λ“ˆμ΄ ν”„λ‘œμ νŠΈμ— μΆ”κ°€λ˜μ—ˆμŠ΅λ‹ˆλ‹€. 이 변경은 μ½”λ“œ 컀버리지 κΈ°λŠ₯을 κ°•ν™”ν•˜κΈ° μœ„ν•œ κ²ƒμœΌλ‘œ λ³΄μž…λ‹ˆλ‹€.


11-11: 디렉토리 μ„€μ • 승인됨

:support:jacoco λͺ¨λ“ˆμ˜ 디렉토리가 μ˜¬λ°”λ₯΄κ²Œ μ„€μ •λ˜μ—ˆμŠ΅λ‹ˆλ‹€. λ””λ ‰ν† λ¦¬μ˜ 쑴재λ₯Ό ν™•μΈν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€.

λ‹€μŒ 슀크립트λ₯Ό μ‹€ν–‰ν•˜μ—¬ λ””λ ‰ν† λ¦¬μ˜ 쑴재λ₯Ό ν™•μΈν•˜μ„Έμš”:

Verification successful

디렉토리 쑴재 확인됨

:support:jacoco λͺ¨λ“ˆμ˜ 디렉토리가 μ‘΄μž¬ν•©λ‹ˆλ‹€. 섀정이 μ˜¬λ°”λ₯΄κ²Œ λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. μΆ”κ°€ μ‘°μΉ˜κ°€ ν•„μš”ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 디렉토리 쑴재 확인
if [ -d "support/jacoco" ]; then
  echo "디렉토리가 μ‘΄μž¬ν•©λ‹ˆλ‹€."
else
  echo "디렉토리가 μ‘΄μž¬ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€."
fi

Length of output: 62

.github/workflows/test_analyze.yaml (1)

1-37: GitHub Actions μ›Œν¬ν”Œλ‘œμš° μ„€μ • 승인됨

ν…ŒμŠ€νŠΈ 및 정적 뢄석을 μœ„ν•œ GitHub Actions μ›Œν¬ν”Œλ‘œμš°κ°€ 잘 μ„€μ •λ˜μ—ˆμŠ΅λ‹ˆλ‹€. JDK 버전과 ν”„λ‘œμ νŠΈ μš”κ΅¬ 사항이 μΌμΉ˜ν•˜λŠ”μ§€ ν™•μΈν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€.

λ‹€μŒ 슀크립트λ₯Ό μ‹€ν–‰ν•˜μ—¬ JDK λ²„μ „μ˜ ν˜Έν™˜μ„±μ„ ν™•μΈν•˜μ„Έμš”:

build.gradle.kts (3)

87-95: SonarQube μ„€μ • 승인됨

SonarQube 섀정이 잘 κ΅¬μ„±λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. ν”„λ‘œμ νŠΈ 킀와 쑰직 섀정이 SonarQube μ„œλ²„ μ„€μ •κ³Ό μΌμΉ˜ν•˜λŠ”μ§€ ν™•μΈν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€.

λ‹€μŒ 슀크립트λ₯Ό μ‹€ν–‰ν•˜μ—¬ SonarQube μ„€μ • 값을 ν™•μΈν•˜μ„Έμš”:

Verification successful

SonarQube μ„€μ • 승인됨

SonarQube 섀정이 잘 κ΅¬μ„±λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. ν”„λ‘œμ νŠΈ 킀와 쑰직 섀정이 SonarQube μ„œλ²„ μ„€μ •κ³Ό μΌμΉ˜ν•˜λŠ”μ§€ ν™•μΈν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# SonarQube μ„€μ • κ°’ 확인
grep 'sonar.' build.gradle.kts

Length of output: 593


108-116: :support:jacoco ν”„λ‘œμ νŠΈ μ„€μ • 승인됨

:support:jacoco ν”„λ‘œμ νŠΈμ— jacoco-report-aggregation ν”ŒλŸ¬κ·ΈμΈμ΄ μ μš©λ˜μ—ˆμœΌλ©°, λ³΄κ³ μ„œ 집계λ₯Ό μœ„ν•œ μ˜μ‘΄μ„± 섀정이 잘 λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. μ˜μ‘΄μ„± 섀정이 λͺ¨λ“  κ΄€λ ¨ ν”„λ‘œμ νŠΈλ₯Ό ν¬ν•¨ν•˜κ³  μžˆλŠ”μ§€ ν™•μΈν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€.

λ‹€μŒ 슀크립트λ₯Ό μ‹€ν–‰ν•˜μ—¬ μ˜μ‘΄μ„± 섀정을 ν™•μΈν•˜μ„Έμš”:

Verification successful

:support:jacoco ν”„λ‘œμ νŠΈ μ„€μ • 확인됨

:support:jacoco ν”„λ‘œμ νŠΈμ˜ 섀정이 λͺ¨λ“  ν”„λ‘œμ νŠΈλ₯Ό JaCoCo λ³΄κ³ μ„œ 집계에 ν¬ν•¨ν•˜λ„λ‘ μ μ ˆν•˜κ²Œ κ΅¬μ„±λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. 좔가적인 μ‘°μΉ˜κ°€ ν•„μš”ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# μ˜μ‘΄μ„± μ„€μ • 확인
grep 'add("jacocoAggregation"' build.gradle.kts

Length of output: 104


98-106: allProjects λ³€μˆ˜ μ„€μ • 승인됨

JaCoCo λ³΄κ³ μ„œ 집계λ₯Ό μœ„ν•΄ ν”„λ‘œμ νŠΈλ₯Ό ν•„ν„°λ§ν•˜λŠ” allProjects λ³€μˆ˜κ°€ 잘 μ„€μ •λ˜μ—ˆμŠ΅λ‹ˆλ‹€. μ œμ™Έλœ ν”„λ‘œμ νŠΈκ°€ μ˜¬λ°”λ₯΄κ²Œ μ‹λ³„λ˜μ—ˆλŠ”μ§€ ν™•μΈν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€.

λ‹€μŒ 슀크립트λ₯Ό μ‹€ν–‰ν•˜μ—¬ μ œμ™Έλœ ν”„λ‘œμ νŠΈλ₯Ό ν™•μΈν•˜μ„Έμš”:

Verification successful

allProjects λ³€μˆ˜ 필터링 확인 μ™„λ£Œ

build.gradle.kts νŒŒμΌμ—μ„œ JaCoCo λ³΄κ³ μ„œ 집계λ₯Ό μœ„ν•΄ νŠΉμ • ν”„λ‘œμ νŠΈκ°€ μ˜¬λ°”λ₯΄κ²Œ μ œμ™Έλ˜κ³  μžˆμŒμ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€. ν•„ν„°λ§λœ ν”„λ‘œμ νŠΈλŠ” "3days-server", "support", "domain", "application", "infrastructure", "bootstrap"μž…λ‹ˆλ‹€. 좔가적인 λ¬Έμ œκ°€ λ°œκ²¬λ˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# μ œμ™Έλœ ν”„λ‘œμ νŠΈ 확인
grep 'filter' build.gradle.kts

Length of output: 269

@waterfogSW waterfogSW merged commit 7b743b0 into main Sep 8, 2024
3 checks passed
@waterfogSW waterfogSW deleted the add-sonar branch September 8, 2024 08:26
@coderabbitai coderabbitai bot mentioned this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant