Updating the parseData #10
Conversation
parseData.py
Outdated
| @@ -126,14 +126,21 @@ def readSerial(ser,data): | |||
| #No packet detected | |||
| else: i+=1 | |||
| print(data) | |||
|
|
|||
| currentDateTime = time.strftime("%Y-%m-%dT%H-%M-%S") | |||
| currentDateTime = 'Logs/ParseDataLog' + currentDateTime + '.txt' | |||
There was a problem hiding this comment.
Variable should be "logFilePath" or etc
There was a problem hiding this comment.
This should be defined in the main section (before getting Y or N)
parseData.py
Outdated
|
|
||
| if __name__ == "__main__": | ||
| ser = None | ||
| data = AvionicsData() | ||
| while(True): | ||
| port = input('Enter a Serial Port to connect to:') #Linux: /dev/ttyUSBx, Windows: COMx | ||
| ser = serial.Serial(port, 9600, timeout=0) | ||
| logFile = input('Do you want to see the current logging of data Yes(Y) or No(N)') | ||
| if logFile == 'Y': | ||
| f = open(currentDateTime, "w") |
parseData.py
Outdated
|
|
||
| if __name__ == "__main__": | ||
| ser = None | ||
| data = AvionicsData() | ||
| while(True): | ||
| port = input('Enter a Serial Port to connect to:') #Linux: /dev/ttyUSBx, Windows: COMx | ||
| ser = serial.Serial(port, 9600, timeout=0) | ||
| logFile = input('Do you want to see the current logging of data Yes(Y) or No(N)') |
There was a problem hiding this comment.
"logFile" should be "logToFile"
parseData.py
Outdated
| if logFile == 'Y': | ||
| f = open(currentDateTime, "w") | ||
| f.write(data) | ||
| if logFile == 'N': | ||
| print('Script has finished running') |
There was a problem hiding this comment.
Execution shouldn't continue until a definite answer has been given.
e.g.:
logToFile = None
while (logToFile == None):
c = input("...").strip().upper()[0]
if (c == 'Y'): logToFile = True
else if (c == 'N'): logToFile = FalseThere was a problem hiding this comment.
Not that logToFile is a boolean after exiting the loop
| f = open(currentDateTime, "w") | ||
| f.write(data) | ||
| if logFile == 'N': | ||
| print('Script has finished running') | ||
|
|
||
| while(ser!=None): | ||
| time.sleep(1) |
There was a problem hiding this comment.
In order to determine if we log to a file, we need to pass the file path to the readSerial(...) function:
readSerial(ser, data, logFilePath if (logToFile) else None)There was a problem hiding this comment.
need to change the readSerial(...) definition to readSerial(ser, data, logFilePath)
| @@ -126,14 +126,21 @@ def readSerial(ser,data): | |||
| #No packet detected | |||
| else: i+=1 | |||
| print(data) | |||
There was a problem hiding this comment.
Right after printing the data, we need to log the same data if needed:
if (logFilePath != None):
with open(logFilePath, 'a') as logFile:
logFile.write(data)… to the AvionicsMockData.py as well
Creates a file within the folder Logs and a file name with the current date as the filename.