Mais um tratamento de index #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edianio
approved these changes
Jan 26, 2024
talesbarreto
suggested changes
Jan 26, 2024
| @@ -737,7 +737,7 @@ - (void)onComplete:(NSNotification *)notification { | |||
| _index = [_order[([_orderInv[_index] intValue] + 1) % _order.count] intValue]; | |||
| [self broadcastPlaybackEvent]; | |||
| _justAdvanced = YES; | |||
| } else if ([_orderInv[_index] intValue] + 1 < [_order count]) { | |||
| } else if (_index < [_orderInv count] && [_orderInv[_index] intValue] + 1 < [_order count]) { | |||
There was a problem hiding this comment.
Tentei mais algumas coisas pra reproduzir esse crash mas em vão...
Estou pensando aqui: se o _index for inválido, em vez de crashar vai car no else que define o estado do player como complete. Estou achando mais safe não fazer absolutamente nada quando o _index for inválido, na esperança do estado, eventualmente, ser atualizado corretamente nas próximas atualizações do AvPlayer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/StudioSol/PalcoMobile/issues/2892