Another bunch of fixes #175
Conversation
|
Please have a look at https://github.com/StylishThemes/Wikipedia-Dark/blob/master/CONTRIBUTING.md#development-scripts
thanks. |
| #mw-content-text .infobox-above[style*="background-color: #c9ffd9;"], | ||
| #mw-content-text .infobox-above[style*="background:#F6DA9F"], | ||
| #mw-content-text .infobox tr[style*="background:#F8C9B0;"] td, |
There was a problem hiding this comment.
Generally, the headers on infoboxes should be light text on a dark background, to match the inverted style of the rest of the page. This would mean finding a darker version of the light background that works well and has a high enough contrast with the text.
Of course, this is an uphill battle, and we would end up adding dozens more colors to our palette (which isn't neccessarily a bad thing). If there is an existing color defined in the style that would work as a replacement, we should use that instead. So either way works, I suppose.
| td[style="background: #4169E1;"], | ||
| td[style="background: #8AB0FF;"], | ||
| tr[style*="background:#E5D8C0;"] > td { | ||
| color: var(--gray-1); |
There was a problem hiding this comment.
A good npm run clean and npm run test would ensure that these are formatted according to the style guide. I'll run them shortly anyway, but ideally the commit should have those corrections already.
|
@Atexor Thanks for the PR. Also take a look at the comment from Joker above, as well as the ones I left on the diff as tips for future contributions. |
| @@ -1990,7 +2053,8 @@ regexp("https?:\/\/wiki\.(archlinux|mozilla)\.(org|jp)\/.*$") { | |||
| .ns-talk .mw-body-content dl dl dl dl dl dl dl dl dl dl, | |||
| .ns-talk .mw-body-content dl dl dl dl dl dl dl dl dl dl dl dl, | |||
| .ns-talk .mw-body-content dl dl dl dl dl dl dl dl dl dl dl dl dl dl, | |||
| table:not([style*="efe"]).wikitable td:not([bgcolor]), table.prettytable td, | |||
| table:not([style*="efe"]):not([background-color:transparent;]).wikitable td:not([bgcolor]), | |||
There was a problem hiding this comment.
I believe this was meant to be :not([style*="background-color:transparent;"])?
Hello,
Another bunch of fixes for following sites:
Additional informations:
figure[typeof*="mw"] > figcaptionin another place. It was necessary for Translation Tool subpage.Have a nice day