-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lsp/hover: Show example links #906
Conversation
c9d34e4
to
2becf0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work here! It's late and I'm OOO, lol, but I left some comments to consider
I think I've addressed everything here, I'll aim to merge tomorrow. |
3a599f1 contains some fixes for head keywords. |
Where examples to https://docs.styra.com/opa/rego-by-example are available, then show the links to these pages. Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Results of benchmarking: old median 28.986063 old mean 99.36704471 new median 20.632625 new mean 84.75417271 new old 170.351834 165.913458 15.080667 18.174667 722.364416 14.838167 144.308166 40.304292 24.4045 22.223417 61.691458 548.937375 171.228291 349.011583 14.812834 19.470125 14.869208 18.471875 46.716167 78.956167 16.760459 15.528125 14.35275 15.014083 14.8865 35.748709 20.632625 48.546583 14.898875 25.510542 15.363084 70.541459 168.860167 17.247625 14.956 These results were tested by disabling all other keyword rule heads and measuring the total time to get the list of keywords in go. Signed-off-by: Charlie Egan <[email protected]>
This is to be used when a list of expressions is needed in rules and for keyword operations. Signed-off-by: Charlie Egan <[email protected]>
I'm merging this in order to allow others to test all the new stuff ahead of a release next week. |
Where examples to https://docs.styra.com/opa/rego-by-example are available, then show the links to these pages.
Screen.Recording.2024-07-09.at.14.10.08.mov