Renderer: Fixes a memory leak with D3D11VP during PresentOffline (eg.…

… called by TakeSnapshot) [Fixes #318]
SuRGeoNix · May 25, 2024 · 678b76f · 678b76f
1 parent 653dde9
commit 678b76f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/FlyleafLib/MediaFramework/MediaDecoder/VideoDecoder.cs b/FlyleafLib/MediaFramework/MediaDecoder/VideoDecoder.cs
@@ -695,6 +695,8 @@ bool oldKeyFrameRequiredPacket
 
     private void RunInternalReverse()
     {
+        // Bug with B-frames, we should not remove the ref packets (we miss frames each time we restart decoding the gop)
+
         int ret = 0;
         int allowedErrors = Config.Decoder.MaxErrors;
         AVPacket *packet;

diff --git a/FlyleafLib/MediaFramework/MediaRenderer/Renderer.PresentOffline.cs b/FlyleafLib/MediaFramework/MediaRenderer/Renderer.PresentOffline.cs
@@ -34,7 +34,8 @@ unsafe internal void PresentOffline(VideoFrame frame, ID3D11RenderTargetView rtv
     {
         if (videoProcessor == VideoProcessors.D3D11)
         {
-            vd1.CreateVideoProcessorOutputView(rtv.Resource, vpe, vpovd, out var vpov);
+            var tmpResource = rtv.Resource;
+            vd1.CreateVideoProcessorOutputView(tmpResource, vpe, vpovd, out var vpov);
 
             RawRect rect = new((int)viewport.X, (int)viewport.Y, (int)(viewport.Width + viewport.X), (int)(viewport.Height + viewport.Y));
             vc.VideoProcessorSetStreamSourceRect(vp, 0, true, VideoRect);
@@ -56,6 +57,7 @@ unsafe internal void PresentOffline(VideoFrame frame, ID3D11RenderTargetView rtv
             vc.VideoProcessorBlt(vp, vpov, 0, 1, vpsa);
             vpiv.Dispose();
             vpov.Dispose();
+            tmpResource.Dispose();
         }
         else
         {