Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RARL force envs #2

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Add RARL force envs #2

merged 7 commits into from
Dec 8, 2023

Conversation

DavidBert
Copy link
Collaborator

No description provided.

Copy link
Member

@AdilZouitine AdilZouitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost good 😄 , just a typo and a question in the tests.
Also, could you run the precommit locally to prevent the precommit action to fail?

@@ -25,6 +31,7 @@
rrls.envs.InvertedPendulumParamsBound.TWO_DIM.value,
rrls.envs.HumanoidStandupParamsBound.THREE_DIM.value,
rrls.envs.Walker2dParamsBound.THREE_DIM.value,
rrls.envs.AntParamsBound.RARL.value,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to add other's env RARL bounds ?


class ForceHumanoidStandUp(Wrapper):
"""
Force HUmanoidStandUp environment. You can apply forces to the environment using the set_params method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo error

Copy link
Member

@AdilZouitine AdilZouitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdilZouitine AdilZouitine merged commit 8f7d1cc into main Dec 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants