Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stdin=subprocess.PIPE to prevent fail on win #1395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apetri
Copy link

@apetri apetri commented Feb 15, 2019

I modified makePDF.py adding a stdin=subprocess.PIPE argument to external_command(); without this building fails on Windows 7

@r-stein
Copy link
Member

r-stein commented Feb 17, 2019

Not sure if this leads to new problems. This build version worked for me on windows 7.

@apetri
Copy link
Author

apetri commented Feb 17, 2019

For some reason it still doesn’t work on mine, subprocess.Popen fails without the stdin argument. It could be my win 7 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants