Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5 "Prevents text selection in console" on version >= 4149, since… #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mark-Joy
Copy link

… it supports "Mousemap contexts": sublimehq/sublime_text#105 (comment)

@FichteFoll
Copy link
Member

FichteFoll commented Nov 18, 2024

This package was made as a workaround for missing mousmap contexts. Now that they have been implemeted in core, the package itself isn't needed anymore, so instead of trying to fix this problem, I'd rather like to know why you are running into this problem in the first place (i.e. using this package) and whether you can get rid of this package.

@FichteFoll
Copy link
Member

That said, I do understand that some old packages may still be indirectly using this package and as a way to ease the migration, I am inclined to merge this PR regardless but I also definitely want to update the readme to indicate that this package is redundant nowadays.

for c in sublime_plugin.all_callbacks.setdefault('on_post_mouse_down',[]):
c.on_post_mouse_down(click_point)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking API change that I cannot merge without a path for migration. However, considering my previous message of phasing out this package, we won't need one.

@Mark-Joy
Copy link
Author

Hi, sorry for the late reply.
I am new to SublimeText, so it took a while for me to figure out what you've said.
I used SidebarHoverToggle which depends MouseEventListener. I didn't know that we can detect 'click on gutter' without MouseEventListener.
Apparently, it was not needed as you your code here just listens to 'on_text_command'.

And I didn't mean to include the second commit 'Expose click-event-arguments to on_post_mouse_down' in this pull request. I was just doing some development on my 'master' branch. Sorry, I am also new to github :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants