Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1157 as a shop owner when saving plans i see oops something is mi #1158

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

chrisjsimpson
Copy link
Contributor

@chrisjsimpson chrisjsimpson commented May 19, 2023

Ref #1157

  • Resolved bug with not checking if customer note is not empty
  • Resolved bug whereby "Require customer note" may be un-checked even if there is a customer note present"
    • This is a change in behaviour- now any customer note message must be deleted when un-checking 'require customer note'
  • Improved error & validation

Before:
image

After:
image

@github-actions
Copy link

@chrisjsimpson chrisjsimpson force-pushed the 1157-as-a-shop-owner-when-saving-plans-i-see-oops-something-is-mi branch from db6aa07 to e4f4efc Compare May 20, 2023 08:41
@github-actions
Copy link

…hing-is-mi' of github.com:Subscribie/subscribie into 1157-as-a-shop-owner-when-saving-plans-i-see-oops-something-is-mi
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant