Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1393 as a shop admin when i get a new subscriber they are added to Mailchimp #1394

Conversation

chrisjsimpson
Copy link
Contributor

Issue ref: #1393

Screenshot before:

image

Screenshot after:

image

image

How to run test(s) for this PR see: Testing

url = f"https://{dc}.api.mailchimp.com/3.0/ping"

# Make the GET request
response = requests.get(url, auth=HTTPBasicAuth("anystring", mailchimp_api_key))

Check failure

Code scanning / CodeQL

Full server-side request forgery Critical

The full URL of this request depends on a
user-provided value
.
Comment on lines +1304 to +1307
response = requests.get(
f"https://{dc}.api.mailchimp.com/3.0/lists/{list_id}",
auth=HTTPBasicAuth("anystring", mailchimp_api_key),
)

Check failure

Code scanning / CodeQL

Full server-side request forgery Critical

The full URL of this request depends on a
user-provided value
.
else:
msg = f"Failed to ping Mailchimp API. Status code: {response.status_code}. Response: {response.text}" # noqa: E501
log.error(msg)
return msg

Check warning

Code scanning / CodeQL

Reflected server-side cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
.
@chrisjsimpson chrisjsimpson merged commit 8c92ccd into master Aug 26, 2024
5 of 7 checks passed
Copy link

🚀 PR was released in v0.1.201 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Aug 26, 2024
Copy link

🚀 PR was released in v0.1.201 🚀

2 similar comments
Copy link

🚀 PR was released in v0.1.201 🚀

Copy link

🚀 PR was released in v0.1.201 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant