Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Remove expired cards from DB and cookie #2076

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

yeseniamolinab
Copy link
Contributor

@yeseniamolinab yeseniamolinab commented Nov 29, 2022

Overview

  • When Braintree responds with an expired card error code during a one-click or express donation transaction, we want to delete the payment method from the DB and the user cookie to prevent this error from happening again, as it is not recommended to keep invalid payment methods on the user vault.

Ticket

https://app.asana.com/0/1119304937718815/1202971390231048/f

Demo of the change

Braintree.Error.Handling.-.29.November.2022.1.mp4

Copy link
Member

@osahyoun osahyoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeseniamolinab this looks good. Would you be able to add some test coverage with a request spec (or two)?

@osahyoun
Copy link
Member

@yeseniamolinab remind me, are you still happy to go live with this?

@yeseniamolinab
Copy link
Contributor Author

@osahyoun If the testing looks good and is done before our code freeze, yes!
I have opened a ticket to complete the specs for this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants