Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ready to PR #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ready to PR #1

wants to merge 2 commits into from

Conversation

hollisjamison
Copy link

No description provided.

@hollisjamison
Copy link
Author

  1. The function tests correctly using npm test
  2. Eslint returns no issues on any of the files (found out to add a .eslintignore to bypass the config file)
  3. I made index.js interactive so it prompts the user for it's two values, then tells you the results in a better form than just true or false.

johnny-rice
johnny-rice approved these changes Jun 23, 2020
View reviewed changes
equal.js
@@ -0,0 +1,7 @@
// Create our strict equal function, tests if dataA is the exact same as B, if so return true, if not false.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

index.js
@@ -0,0 +1,29 @@
// this pulls the code from equal.js and renames it to run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the slides reference var. When we see them though, we should replace them with let. var can safely never be used in nodejs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnny-rice johnny-rice johnny-rice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hollisjamison @johnny-rice