Passing Receptionist to each plugin #372
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. For no apparent reason I thought it's cleaner to replace make the communication between the plugins and the receptionist more explicit.
I.e. let the plugins send directly to the receptionist instead of shouting loud in the open (
context.system.eventStream.publish).Somehow it fails for the http-receptionist tests. I fail to understand them and have hard time trying to fix them. I can only guess - the failing test doesn't reproduce the full bootstrap/init sequence, thus it doesn't go through the
InitializePlugin