Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add TransformedPointLimitedEulerSameAsUnlimitedEuler3D unit test #560

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ENH: Add TransformedPointLimitedEulerSameAsUnlimitedEuler3D unit test #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad64423
ENH: Add TransformedPointLimitedEulerSameAsUnlimitedEuler3D unit test
N-Dekker Dec 10, 2021
c138ff6
ENH: Add TransformedImageLimitedEulerSameAsUnlimitedEuler3D unit test
N-Dekker Dec 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions Common/GTesting/elxTransformIOGTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
#include "TranslationTransform/elxTranslationTransform.h"
#include "WeightedCombinationTransform/elxWeightedCombinationTransform.h"

#include "itkAdvancedLimitedEuler3DTransform.h"

#include <itkAffineTransform.h>
#include <itkBSplineTransform.h>
#include <itkCompositeTransform.h>
Expand Down Expand Up @@ -972,3 +974,39 @@ GTEST_TEST(Transform, TransformedPointSameAsITKBSpline3D)

Expect_elx_TransformPoint_yields_same_point_as_ITK<elx::AdvancedBSplineTransform>(itkTransform);
}


// Tests that the limited Euler transform yields the same point-to-point transformation as the unlimited Euler
// transform, when there is no limit specified.
GTEST_TEST(Transform, TransformedPointLimitedEulerSameAsUnlimitedEuler3D)
{
std::mt19937 randomNumberEngine;

// Generated another pseudo-random floating point number with each call.
const auto getRandomNumber = [&randomNumberEngine] {
const std::uniform_real_distribution<> distribution{ -1.0, 1.0 };
return distribution(randomNumberEngine);
};

for (const bool computeZYX : { false, true })
{
const auto unlimitedTransform = CheckNew<itk::AdvancedEuler3DTransform<double>>();
unlimitedTransform->SetCenter(MakePoint(getRandomNumber(), getRandomNumber(), getRandomNumber()));
unlimitedTransform->SetComputeZYX(computeZYX);
unlimitedTransform->SetTranslation(MakeVector(getRandomNumber(), getRandomNumber(), getRandomNumber()));
unlimitedTransform->SetRotation(getRandomNumber(), getRandomNumber(), getRandomNumber());

const auto limitedTransform = CheckNew<itk::AdvancedLimitedEuler3DTransform<double>>();

// Copy all the relevant properties from the "unlimited" to the "limited" Euler transform.
limitedTransform->SetCenter(unlimitedTransform->GetCenter());
limitedTransform->SetComputeZYX(unlimitedTransform->GetComputeZYX());
limitedTransform->SetTranslation(unlimitedTransform->GetTranslation());
limitedTransform->SetRotation(
unlimitedTransform->GetAngleX(), unlimitedTransform->GetAngleY(), unlimitedTransform->GetAngleZ());

const auto inputPoint = MakePoint(getRandomNumber(), getRandomNumber(), getRandomNumber());

EXPECT_EQ(limitedTransform->TransformPoint(inputPoint), unlimitedTransform->TransformPoint(inputPoint));
}
}
72 changes: 72 additions & 0 deletions Core/Main/GTesting/itkTransformixFilterGTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
#include "elxDefaultConstructibleSubclass.h"
#include "GTesting/elxGTestUtilities.h"

#include "itkAdvancedEuler3DTransform.h"
#include "itkAdvancedLimitedEuler3DTransform.h"

// ITK header files:
#include <itkAffineTransform.h>
#include <itkBSplineTransform.h>
Expand Down Expand Up @@ -689,3 +692,72 @@ GTEST_TEST(itkTransformixFilter, CombineTranslationAndScale)
EXPECT_EQ(DerefSmartPointer(transformixOutput),
*(CreateResampleImageFilter(*inputImage, scaleAndTranslationTransform)->GetOutput()));
}


// Tests that the limited Euler transform yields the same image-to-image transformation as the unlimited Euler
// transform, when there is no limit specified.
GTEST_TEST(itkTransformixFilter, TransformedImageLimitedEulerSameAsUnlimitedEuler3D)
{
enum
{
ImageDimension = 3
};
using TPixel = float;
using ImageType = itk::Image<TPixel, ImageDimension>;

const auto image = CreateImageFilledWithSequenceOfNaturalNumbers<TPixel, ImageDimension>({ 7, 8, 9 });

const auto transformImage = [&image](const char * const transformName,
const auto & transform) -> itk::SmartPointer<ImageType> {
const auto filter = CheckNew<itk::TransformixFilter<itk::Image<TPixel, ImageDimension>>>();

const auto & transformParameters = transform.GetParameters();

filter->SetMovingImage(image);

filter->SetTransformParameterObject(
CreateParameterObject({ // Parameters in alphabetic order:
{ "CenterOfRotationPoint", elx::Conversion::ToVectorOfStrings(transform.GetCenter()) },
{ "Direction", CreateDefaultDirectionParameterValues<ImageDimension>() },
{ "Index", ParameterValuesType(ImageDimension, "0") },
{ "NumberOfParameters", { std::to_string(transformParameters.size()) } },
{ "Origin", ParameterValuesType(ImageDimension, "0") },
{ "ResampleInterpolator", { "FinalLinearInterpolator" } },
{ "Size", ConvertToParameterValues(image->GetRequestedRegion().GetSize()) },
{ "Transform", ParameterValuesType{ transformName } },
{ "TransformParameters", elx::Conversion::ToVectorOfStrings(transformParameters) },
{ "Spacing", ParameterValuesType(ImageDimension, "1") } }));
filter->Update();
return filter->GetOutput();
};

std::mt19937 randomNumberEngine;

// Generated another pseudo-random floating point number with each call.
const auto getRandomNumber = [&randomNumberEngine] {
const std::uniform_real_distribution<> distribution{ -1.0, 1.0 };
return distribution(randomNumberEngine);
};

for (const bool computeZYX : { false, true })
{
const auto unlimitedTransform = CheckNew<itk::AdvancedEuler3DTransform<double>>();
unlimitedTransform->SetCenter(MakePoint(getRandomNumber(), getRandomNumber(), getRandomNumber()));
unlimitedTransform->SetComputeZYX(computeZYX);
unlimitedTransform->SetTranslation(MakeVector(getRandomNumber(), getRandomNumber(), getRandomNumber()));
unlimitedTransform->SetRotation(getRandomNumber(), getRandomNumber(), getRandomNumber());

const auto limitedTransform = CheckNew<itk::AdvancedLimitedEuler3DTransform<double>>();

// Copy all the relevant properties from the "unlimited" to the "limited" Euler transform.
limitedTransform->SetCenter(unlimitedTransform->GetCenter());
limitedTransform->SetComputeZYX(unlimitedTransform->GetComputeZYX());
limitedTransform->SetTranslation(unlimitedTransform->GetTranslation());
limitedTransform->SetRotation(
unlimitedTransform->GetAngleX(), unlimitedTransform->GetAngleY(), unlimitedTransform->GetAngleZ());

const auto unlimitedTransformedImage = transformImage("EulerTransform", *unlimitedTransform);
const auto limitedTransformedImage = transformImage("LimitedEulerTransform", *limitedTransform);
EXPECT_EQ(DerefSmartPointer(limitedTransformedImage), DerefSmartPointer(unlimitedTransformedImage));
}
}