Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Set CMAKE VISIBILITY_PRESET to hidden #636

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

COMP: Set CMAKE VISIBILITY_PRESET to hidden #636

wants to merge 1 commit into from

Commits on Apr 14, 2022

  1. COMP: Set CMAKE VISIBILITY_PRESET to hidden 

    Suggested by Bradley Lowekamp at "WIP: Support adding Elastix component by CMake SimpleITK_USE_ELASTIX=ON" comment SimpleITK/SimpleITK#1611 (comment) referring to https://github.com/SimpleITK/SimpleITK/blob/2681d0689a5922a7f2d1b56b1c7b62361eed9d8d/SuperBuild/External_ITK.cmake#L81-L83

Discussed with Marius Staring at superelastix.slack.com #elastix

Aims to avoid link warnings in SimpleITK (+ Elastix component), like
> ld: warning: direct access in function '...' from file '....cxx.o)' to global weak symbol 'typeinfo for ...' from file '....cxx.o' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.

At at https://open.cdash.org/viewBuildError.php?type=1&buildid=7827932 ( Azure Pipelines 2-macOS)
    @N-Dekker
    N-Dekker committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    d6231d3 View commit details
    Browse the repository at this point in the history