Don't replace transaction if credit is owed

It turns out that `Order#paid?` returns `true` even if credit is owed.
So we want to explicitly check that the order's payment state is "paid"
and not some other value, like "credit_owed".

Co-Authored-By: Noah Silvera <[email protected]>

app/subscribers/super_good/solidus_taxjar/spree/reporting_subscriber.rb

@@ -21,9 +21,8 @@ def replace_transaction(event)
           order = event.payload[:order]
 
           return unless SuperGood::SolidusTaxjar.configuration.preferred_reporting_enabled
-          return unless transaction_replaceable?(order)
 
-          if order.complete? && order.paid? && amount_changed?(order)
+          if transaction_replaceable?(order) && amount_changed?(order)
             SuperGood::SolidusTaxjar::ReplaceTransactionJob.perform_later(event.payload[:order])
           end
         end
@@ -36,7 +35,9 @@ def amount_changed?(order)
         end
 
         def transaction_replaceable?(order)
-          order.taxjar_order_transactions.present?
+          order.taxjar_order_transactions.present? &&
+            order.complete? &&
+              order.payment_state == "paid"
         end
       end
     end

spec/subscribers/super_good/solidus_taxjar/spree/reporting_subscriber_spec.rb

@@ -36,7 +36,22 @@ def with_events_disabled(&block)
         end
       end
 
-      context "when the order is paid" do
+      context "when the order's payment state is 'credit_owed'" do
+        let(:order) {
+          with_events_disabled {
+            create(order_factory, payment_state: "credit_owed")
+          }
+        }
+
+        it "does nothing" do
+          expect(reporting)
+            .not_to receive(:refund_and_create_new_transaction)
+
+          subject
+        end
+      end
+
+      context "when the order's payment state is 'paid'" do
         context "when a TaxJar transaction already exists on the order" do
           let!(:taxjar_transaction) { create(:taxjar_order_transaction, order: order) }
 
@@ -174,8 +189,8 @@ def with_events_disabled(&block)
         end
       end
 
-      context "when the order is not paid" do
-        let(:order_factory) { :order_with_totals }
+      context "when the order's payment state is 'balance_due'" do
+        let(:order_factory) { :completed_order_with_pending_payment }
 
         it "does nothing" do
           expect(reporting).not_to receive(:show_or_create_transaction)