Use correct source label for metrics #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As go captures by reference we need to ensure each pinger's callbacks uses the source the current pinger or they will all wind up reporting the source from the last pinger. Signed-off-by: Tom Hughes <[email protected]>
|
Close/Open to fix the CI triggers. |
SuperQ
added a commit
that referenced
this pull request
Mar 10, 2024
* [BUGFIX] Fix incorrect label setting #141 #142 Signed-off-by: SuperQ <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on #141 to avoid conflicts.
As go captures by reference the callbacks hold
pingerby reference and they will all wind up taking the source from the last pinger the loop processes.Assigning source to a local variable that ensures that each pinger's callbacks capture a reference to that variable which is unique to each pinger and hence that the correct source is reported.