Make object option generic #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusGuy
reviewed
Sep 9, 2023
|
tobbi has the best commit messages |
tobbi
requested review from
MatusGuy,
mrkubax10 and
Vankata453
and removed request for
MatusGuy
Vankata453
reviewed
Sep 12, 2023
MatusGuy
approved these changes
Sep 12, 2023
mrkubax10
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Apply @Vankata453's suggestions and it will be good to merge.
tobbi
force-pushed
the
rework-object-options
branch
from
57fcc91 to
2132110
Compare
Vankata453
approved these changes
Sep 16, 2023
mrkubax10
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Sponges grow in the ocean. That just kills me. I wonder how much deeper the ocean would be if that didn't happen." - Steve Wright (from https://www.brainyquote.com/authors/steven-wright-quotes)
Fixes #2632