Make rumble functions configurable #2742
Conversation
|
Wait, I completely forgot about joysticks (and left in a mistake during a rebasing mistake) that skips most of the conditions. |
n0toose
force-pushed
the
rumble-overload
branch
from
fb6976f to
226e759
Compare
|
Should hopefully be good to go? (Note: I don't own a joystick, so the changes affecting the joystick component are untested - even if they are presumed to be fine.) |
n0toose
changed the title
mrkubax10
added
type:feature
category:code
status:needs-review
src/control/joystick_manager.cpp
Outdated
| JoystickManager::rumble(SDL_Joystick* controller) const | ||
| JoystickManager::rumble(SDL_Joystick* joystick) const | ||
| { | ||
| return this->rumble(joystick, 0xFFFF, 0xFFFF, 100); |
src/control/joystick_manager.hpp
Outdated
| #include "control/controller.hpp" | ||
|
|
||
| #include <stdint.h> | ||
| #include <vector> | ||
| #include <unordered_map> | ||
|
|
||
| #include "control/controller.hpp" | ||
| #include <SDL.h> |
|
Besides my previous comments maybe it would make sense to add rumble configuration to options menu? Because currently this change seems little bit pointless. |
I haven't completed my work in trying to get
I do not know if I should do that yet, as that would require me to answer the following: Should I use the Later on, I'd like to use information such as the direction that a player was hit from or whether the player got a fire flower more easily later. |
|
I think you should trigger rumble when there's any type of screenshake, which does not require player |
Hm, would be a good start and one could immediately combine it with #2741. |
Affects GameControllerManager::rumble() and JoystickManager::rumble(). The functions were overloaded so as to be made configurable, but there is a default rumble (that now lasts 100ms instead of 300ms). Just a small refactoring job.
n0toose
force-pushed
the
rumble-overload
branch
from
226e759 to
b1e6f7c
Compare
I'll look at whether I can get the Camera class to talk to GameControllerManager. |
|
it's not a singleton? |
Affects GameControllerManager::rumble() and JoystickManager::rumble().
The functions were overloaded so as to be made configurable, but there
is a default rumble (that now lasts 100ms instead of 300ms).
Just a small refactoring job.
I have not figured out how to expose the rumble function to Player.cpp in a clean way yet, but this is a start.
Related to #2741.