Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PulsingLight: Move and change colour together with tilemap #3167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hume2
Copy link
Member

@Hume2 Hume2 commented Jan 5, 2025

When a tilemap has lava or torches, they create PulsingLight objects. However, these objects are stuck at the original state of the tilemaps and never update throughout the gameplay. This pull request fixes this behaviour.

Testing level:
level2.zip

Copy link
Member

@MatusGuy MatusGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, haven't tested this in game

src/object/pulsing_light.cpp Outdated Show resolved Hide resolved
src/object/pulsing_light.cpp Outdated Show resolved Hide resolved
@Frostwithasideofsalt
Copy link
Member

image
doesnt seem to work- ill redownload this PR in the morning just to double check if i have the right one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants