Catch notfound exception on deleting non existing file #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
@matthewgoslett can you have a look at this please? 👍 |
|
@matthewgoslett poke ;) |
|
@matthewgoslett poke :) |
1 similar comment
|
@matthewgoslett poke :) |
|
Hey. Sorry, I haven't been at the organisation Superbalist for quite a few
years now and am no longer involved in this project.
…On Wed, 11 Jan 2023 at 22:33, Stefan van Essen ***@***.***> wrote:
@matthewgoslett <https://github.com/matthewgoslett> poke :)
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL7XH5IGGUU3K4BHEIIPPDWR4RJXANCNFSM5FOVT4IQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
|
Hi @matthewgoslett thanks for letting me know, is there anyone else I could reach out to? |
|
@shad0wfir3 It seems you are the last person to have merged something, can I ask you to look at this PR? I'm not quite sure how to mention @superbalist/core from the CODEOWNERS file, but saw your name. |
|
@shad0wfir3 poke :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Projects using FlySystem can use League\Flysystem\AdapterInterface::deleteDir() to remove a directory from a filesystem.
This should return a boolean to indicate whether this succeeded. This GCP implementation does however throw an exception.
This Pull Request fixes the issue.
An example where this happens is in Shopware 6, described here shopware/shopware#2108
Reproduction
The fix
The fix is quite easy actually: catch the exception thrown by the Google Cloud PHP API, so this implementation of the AdapterInterface matches the expected behaviour.