Skip to content
This repository has been archived by the owner on Jul 19, 2024. It is now read-only.

Google lib upgrade again #17

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,17 @@ matrix:
env: TOXENV=py35
- python: "3.6"
env: TOXENV=py36
- python: "3.7"
env: TOXENV=py36
tiaanwillemse marked this conversation as resolved.
Show resolved Hide resolved
- python: "3.8"
env: TOXENV=py36
tiaanwillemse marked this conversation as resolved.
Show resolved Hide resolved

# Meta
- python: "3.6"
- python: "3.8"
env: TOXENV=flake8
- python: "3.6"
- python: "3.8"
env: TOXENV=manifest
- python: "3.6"
- python: "3.8"
env: TOXENV=readme


Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [1.0.1] - 2020-05-15
- Updated google.cloud.pubsub dependency to 1.5.0

## [1.0.0] - 2018-11-21
- [BREAKING] No longer supports python 2
- Cache the results of get_topic
Expand All @@ -22,6 +25,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
## [0.3.6] - 2015-12-03

[Unreleased]: https://github.com/Superbalist/python-pubsub/compare/1.0.0...HEAD
[1.0.1]: https://github.com/Superbalist/python-pubsub/compare/1.0.0...1.0.1
[1.0.0]: https://github.com/Superbalist/python-pubsub/compare/0.3.9...1.0.0
[0.3.9]: https://github.com/Superbalist/python-pubsub/compare/0.3.8...0.3.9
[0.3.8]: https://github.com/Superbalist/python-pubsub/compare/0.3.7...0.3.8
Expand Down
3 changes: 1 addition & 2 deletions pubsub/adapters/googlecloud.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ def subscribe(self, topic_name, callback, create_topic=False):
subscription_path = self.subscriber.subscription_path(self.project_id, '{}.{}'.format(self.client_identifier, topic_name))

log.info('Starting to listen on: %s', subscription_path)
policy = self.subscriber.subscribe(subscription_path)
return policy.open(callback=callback)
return self.subscriber.subscribe(subscription_path, callback)

def get_subscription(self, topic_name, create_topic=False):
if not self.client_identifier:
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
google.cloud.pubsub>=0.33.1
google-cloud-pubsub>=1.5.0
jsonschema
requests
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
name='pubsub.py',
author='Superbalist Engineering',
author_email='[email protected]',
version='1.0.0',
version='1.0.1',
description='Python PubSub Adapter for gcloud',
long_description='Python PubSub Adapter for gcloud',
url='https://github.com/Superbalist/python-pubsub',
install_requires=[
'google.cloud.pubsub==0.33.1',
'google-cloud-pubsub==1.5.0',
'jsonschema',
'requests',
],
Expand Down
19 changes: 16 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,38 @@ commands = coverage run --parallel -m pytest {posargs}


[testenv:py36]
basepython = python3.6
deps = -rdev-requirements.txt
commands = coverage run --parallel -m pytest {posargs}


[testenv:py37]
basepython = python3.7
deps = -rdev-requirements.txt
commands = coverage run --parallel -m pytest {posargs}


[testenv:py38]
basepython = python3.8
deps = -rdev-requirements.txt
commands = coverage run --parallel -m pytest {posargs}


[testenv:flake8]
basepython = python3.6
basepython = python3.8
deps = flake8
commands = flake8 pubsub tests setup.py conftest.py docs/conf.py


[testenv:manifest]
basepython = python3.6
basepython = python3.8
tiaanwillemse marked this conversation as resolved.
Show resolved Hide resolved
deps = check-manifest
skip_install = true
commands = check-manifest


[testenv:readme]
basepython = python3.6
basepython = python3.8
tiaanwillemse marked this conversation as resolved.
Show resolved Hide resolved
deps = readme_renderer
skip_install = true
commands = python setup.py check -r -s
Expand Down