Improve Genius title matching

[aadibajpai]

issues in mind:

• current comparison checks for list elements in a string, the disadvantage of this is that partial matches will return true, as in 'na' in 'banana' or 'sass' in 'assassination' will return true but with list comparison, 'na' in ['banana'] will return false.

• one sort of false positives is when a different song of the same artist is returned. eg.
  
  this can be fixed by checking the song name specifically but then

• this creates a problem with how the discord bot works, people are supposed to specify song artist like "rap god" "eminem" but no one bothers to read help so they just do rap god eminem, which gets treated as song=rap, artist=god, the bot still manages to return lyrics because of lax matching.

• for remixes, song name will remain same but artist might be referring to the remix artist which would again trip up the matcher if artist is specifically compared.

Signed-off-by: Aadi Bajpai [email protected]

[codecov]

Codecov Report

Merging #36 into master will increase coverage by 0.79%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   82.33%   83.13%   +0.79%     
==========================================
  Files           3        3              
  Lines         419      581     +162     
  Branches       56       96      +40     
==========================================
+ Hits          345      483     +138     
- Misses         73       94      +21     
- Partials        1        4       +3     

Impacted Files	Coverage Δ
swaglyrics_backend/issue_maker.py	85.53% <85.00%> (-0.18%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b8c4c...d253a1c. Read the comment docs.

[aadibajpai]

@thealphadollar, tested with actual data, splitting before checking seems to work.

[thealphadollar]

A small suggestion, rest looks good to me.

Have you thought about solving the challenges you've mentioned in the description?

[aadibajpai]

Have you thought about solving the challenges you've mentioned in the description?

this solves those! the split() takes care of the first one and the second and third one are addressed when the artist is checked and the fourth one is for the discord cases.

[thealphadollar]

Have you thought about solving the challenges you've mentioned in the description?

this solves those! the split() takes care of the first one and the second and third one are addressed when the artist is checked and the fourth one is for the discord cases.

That's pretty cool. I got primarily confused with the description since it mentioned only the issues in detail. Good to go!