-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt linkable paths #2482
Adopt linkable paths #2482
Conversation
We shouldn't deploy this until the re-generation has completed to avoid Google seeing empty sitemaps where they were previously full of data. |
If you trigger a build for the doc build version via the |
I'm deploying this branch to dev to test that and I'll kick off a SwiftSyntax build, too |
2f98ac9
to
1e327fa
Compare
This has had less of a performance impact than I hoped it would. StreamChatSwiftUI on production, with the huge This is still a step in the right direction, but we may want to look further at what's taking it so long to run. Slightly more worrying, and why I am not going to merge this yet is that the files from prod/staging are different sizes. I am struggling to find anything that can diff them, but I'll write a little script tomorrow to extract just the urls and diff those. |
OK I wrote the script tonight as it was bugging me why these would be different, and the good news is that they are not. There were just How do I even function as a human being? 🙄 |
I'll merge and deploy this tomorrow. |
Deploying as 2.88.1 |
Only a negligible increase in performance. Before:
After:
|
Fixes #2471
Hard to test the performance on dev as I don't think we have any of the huge packages with the files there, but we can test it on prod once it's deployed and the documentation re-generation has completed.