Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a maximum length for the SPI manifest validator #2483

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Add a maximum length for the SPI manifest validator #2483

merged 3 commits into from
Jul 4, 2023

Conversation

daveverwer
Copy link
Member

Fixes #2407

@cla-bot cla-bot bot added the cla-signed label Jul 4, 2023
@daveverwer daveverwer enabled auto-merge July 4, 2023 14:58
finestructure
finestructure approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@finestructure finestructure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled the auto merge so the approval doesn't merge it in case you want to change the limit source.

Sources/App/Views/ValidateSPIManifest/ValidateSPIManifest+View.swift Outdated Show resolved Hide resolved
@daveverwer daveverwer enabled auto-merge July 4, 2023 16:01
@daveverwer daveverwer merged commit d06c71e into main Jul 4, 2023
4 checks passed
@daveverwer daveverwer deleted the fix-2407 branch July 4, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finestructure finestructure finestructure approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

“Content missing” on SPI manifest validator
2 participants
@daveverwer @finestructure