Add “Has Documentation” Tag to Author and Keyword Views

[luis-gustavo]

Issue

Closes #3413

Description

This pull request adds the “Has Documentation” tag to the Author and Keyword views, ensuring consistency with the Search view, where this tag was already present.

The implementation involved updating PackageInfo to include the hasDocumentation property from scoreDetails.

Screenshots

• Search

• Authors

• Keywords

[cla-bot]

Thanks so much for submitting a pull request. We appreciate your contribution!

We require all contributors to sign our Contributor License Agreement (CLA) before we can merge any code, and we don't currently have a record of a signed CLA for @luis-gustavo. Please email [email protected] and let us know you need to sign a CLA, and we'll get the template over to you.

[daveverwer]

What a great start, thanks so much for your contribution @luis-gustavo! We really appreciate it.

I tested it locally and all looks good. The only change I'd make is to modify the mock objects for the keyword and author view snapshot tests so that we get the "Has documentation" flair showing in our snapshots to make sure we never break this.

The tests are test_KeywordShow() and test_AuthorShow() and you can find the mocks in KeywordShow+mock.swift and AuthorShow+mock.swift.

[daveverwer]

What a great start, thanks so much for your contribution @luis-gustavo! We really appreciate it.

I tested it locally and all looks good. The only change I'd make is to modify the mock objects for the keyword and author view snapshot tests so that we get the "Has documentation" flair showing in our snapshots to make sure we never break this.

The tests are test_KeywordShow() and test_AuthorShow() and you can find the mocks in KeywordShow+mock.swift and AuthorShow+mock.swift.

Also, to update the snapshots change .missing to .all in SnapshotTestCase.swift and run the tests.

[daveverwer]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[luis-gustavo]

Hi @daveverwer, thanks for the feedback. I have updated the mocks and the snapshot tests. Can you please review again?

[daveverwer]

Thank you so much, @luis-gustavo! We really appreciate the help.

[daveverwer]

Deploying as 2.116.2