Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a view for one coffee-making step #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add a view for one coffee-making step #22

wants to merge 1 commit into from

Conversation

ncossor
Copy link
Collaborator

@ncossor ncossor commented Mar 9, 2020 •
edited
Loading

Added a loader (no error handling yet) and view to show an image loaded from a URL
Added a prototype view for one coffee-making step, with "subviews" based on properties of the step
Added more test data, plus some previews

As discussed, we probably need

  • a view for showing the ingredients (probably with a stepper to adjust the # of cups)
  • a view for showing the equipment
  • possibly (given small # of elements in each of previous) a view which contains both of them
  • some controller (?view) which controls which of the views is showing and if in "steps", which one we are up to

pouriaalmassi
pouriaalmassi approved these changes Jun 14, 2020
View reviewed changes
Copy link
Collaborator

@pouriaalmassi pouriaalmassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pouriaalmassi pouriaalmassi pouriaalmassi approved these changes

@jimmyhoran jimmyhoran Awaiting requested review from jimmyhoran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncossor @pouriaalmassi