Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new homepage hero #89

Closed
johnhutch opened this issue May 11, 2017 · 10 comments
Closed

Create new homepage hero #89

johnhutch opened this issue May 11, 2017 · 10 comments
Assignees
@arbitrarynoun
Labels
design

Comments

@johnhutch
Copy link
Collaborator

johnhutch commented May 11, 2017 •
edited by arbitrarynoun
Loading

issue_89-new_hero Edit July 1, 2017

Something like this:

img_8200
@arbitrarynoun
Copy link
Collaborator

untitled-2

I thought maybe something like this, but better, and with how long THIS took me I know I'm not the person to do the final draft.

@johnhutch
Copy link
Collaborator Author

Funny, i was thinking arrows, but I couldn't draw them. But I was thinking just screenshots. I like the idea of including the final screenshot IN the phone. That's really demonstrative.

@johnhutch johnhutch mentioned this issue May 12, 2017
Closed
@arbitrarynoun arbitrarynoun self-assigned this Jun 9, 2017
@johnhutch
Copy link
Collaborator Author

johnhutch commented Jun 22, 2017 •
edited
Loading

Putting this in the correct ticket:

foodweek_header

@johnhutch johnhutch changed the title Homepage needs a new hero that demonstrates core use Create new homepage hero Jun 22, 2017
@arbitrarynoun arbitrarynoun self-assigned this Jun 30, 2017
@arbitrarynoun
Copy link
Collaborator

Going to try to build that cycle graphic, but going to try to figure out the safest width to plan for.

arbitrarynoun added a commit that referenced this issue Jul 1, 2017
@arbitrarynoun
issue #89: added flow chart blockers (all three with arrows) and scre…
fb04ce1 
…en grab blockers (separate rectangles) at various resolutions. started plugging them into the homepage to see what's what.
arbitrarynoun added a commit that referenced this issue Jul 5, 2017
@arbitrarynoun
issue #89: more CSS tweaks, including a nicely responsive logo when t…
044c023 
…he viewport forces the content to stack vertically. Doesn't look as good at desktop size, though. More work needed.
arbitrarynoun added a commit that referenced this issue Jul 5, 2017
@arbitrarynoun
issue #89: commented out the old screen shots and made some css adjus…
cf07a87 
…tments. Still a lot of vertical space wasted... more work needed.
arbitrarynoun added a commit that referenced this issue Jul 6, 2017
@arbitrarynoun
issue #89: Added vertical logo for portrait phones. CSS inclusion wit…
a6dcdb8 
…h breakpoints. More work needed.
@arbitrarynoun
Copy link
Collaborator

arbitrarynoun commented Jul 6, 2017 •
edited
Loading

Getting some image blur due to downscaling... link to pursue a solution:
https://superuser.com/questions/530317/how-to-prevent-chrome-from-blurring-small-images-when-zoomed-in

Edit: Creating a new issue for this. See Issue #142.

@johnhutch
Copy link
Collaborator Author

@arbitrarynoun Good find on that link. Let's wrap this up and create a new ticket to handle the downscaling issue. We may need to discuss a bit, decide what approach we want to take. I'm not familiar enough with this issue to have an opinion without doing a bit of reading.

arbitrarynoun added a commit that referenced this issue Jul 6, 2017
@arbitrarynoun
issue #89: Looking good now. Code cleaned up, sufficiently responsive…
73c95cc 
…. Possibly redundant files still in the system (unused image files), but looking for input there. Ready for review.)

git push
git commit --amend -m issue
arbitrarynoun added a commit that referenced this issue Jul 6, 2017
@arbitrarynoun
issue #89: Commenting out the old screen shots created guard failures…
de245b3 
…, so I put them back in to pass tests.
arbitrarynoun added a commit that referenced this issue Jul 6, 2017
@arbitrarynoun
issue #89: Paris told me to push the failing version since that's lik…
83506df 
…ely how we'll want it to look in the future. Submitting for code review.
@jon-athan-hall
Copy link
Contributor

I'm taking this to fix the tests. Then I'll give it to Hutch for final code review.

@arbitrarynoun arbitrarynoun mentioned this issue Jul 6, 2017
Closed
arbitrarynoun added a commit that referenced this issue Jul 6, 2017
@arbitrarynoun
issue #89: Found the reason (with help) for the Guard fails and fixed…
886f6de 
… them. Pushing a guard passing version for code review. Cheers.
@arbitrarynoun
Copy link
Collaborator

Ready for Review. Sorry, @jon-athan-hall , we handled those tests already.

@arbitrarynoun arbitrarynoun mentioned this issue Jul 6, 2017
Open
@jon-athan-hall
Copy link
Contributor

New hero is up! It's missing stuff, but I'm assuming that's over in #88.

@arbitrarynoun this is ready for a second round of QA by the original dev (that's you!).

johnhutch added a commit that referenced this issue Jul 7, 2017
@johnhutch
Issue #89 -- added asset path helpers to scss
0b5e47d
@arbitrarynoun
Copy link
Collaborator

Super sweet. Thanks for your help, team. Closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbitrarynoun arbitrarynoun

Labels
design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnhutch @jon-athan-hall @arbitrarynoun