Connected and typed dimensions #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DatasetExactlyOneContents -> DatasetMaxOneContents - DatasetExactlyOneGraph -> DatasetMinOneGraph - DatasetExactlyOneLabel removed - DatasetExactlyOneTitle added - DatasetMaxOneContributor removed - RecordExactlyOneLabel removed
…et->contents is MaxOne
Also rewrote suite.edn as it had merge conflict that seem just to be the format
Cherry-picked from #8.
… that component properties have codelists
This removes the expectation that concepts provide a single rdfs:label. Instead they may provide multiple different labels if a single skos:prefLabel per language has been identified. The ConceptMaxOneLabelIfNoPrefLabel.sparql validation ought later be made a warning as this won't break the UI (it'll just mean the user hasn't made an explicit choice when they ought to have).
Dataset dcat:modified, dcat:issued are now optional
Reinstate PMD Dataset required issued validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test that ensures that Dimensions are connected to a DataCube and that they are typed as
qb:Dimension. This allows us to simplify the dimensions must have a concept in the code list test by removing the basic graph pattern that links the dimension to the data cube.