Minor changes

.gitignore

@@ -1,7 +1,4 @@
 /vendor
-/var/cache/
-/var/logs/
-/var/data/*.sqlite
-!/var/data/.gitkeep
+/var
 /composer.lock
 /.phpunit.cache

src/Command/GmvCommand.php

@@ -19,10 +19,10 @@
 use Sylius\GmvBundle\Validator\InputParametersValidatorInterface;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Helper\ProgressIndicator;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-use Webmozart\Assert\Assert;
 
 #[AsCommand(
     name: 'sylius:gmv:calculate',
@@ -61,20 +61,22 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $periodStart = $input->getArgument('periodStart');
         $periodEnd = $input->getArgument('periodEnd');
 
-        Assert::string($periodStart);
-        Assert::string($periodEnd);
-
-        if (!$this->validator->validate($periodStart, $periodEnd)) {
+        if (!is_string($periodStart) || !is_string($periodEnd) || !$this->validator->validate($periodStart, $periodEnd)) {
             $output->writeln('<error>Invalid format or start date must be less than end date. Please use MM/YYYY.</error>');
 
             return Command::FAILURE;
         }
 
+        $progressIndicator = new ProgressIndicator($output);
+        $progressIndicator->start('Calculating GMV...');
+
         $startDate = $this->dateParser->parseStartOfMonth($periodStart);
         $endDate = $this->dateParser->parseEndOfMonth($periodEnd);
 
         $gmvs = $this->gmvProvider->getGmvForPeriod($startDate, $endDate);
 
+        $progressIndicator->finish('Finished!');
+
         $output->writeln('<info>GMV Calculation</info>');
         $output->writeln(sprintf('<comment>Period Start:</comment> %s', $startDate->format('Y-m-d')));
         $output->writeln(sprintf('<comment>Period End:</comment> %s', $endDate->format('Y-m-d')));

src/Provider/GmvProvider.php

@@ -67,12 +67,12 @@ private function calculateGmvForPeriodAndCurrency(\DateTimeInterface $periodStar
         $queryBuilder->andWhere('o.currencyCode = :currencyCode')
             ->setParameter('currencyCode', $currencyCode);
 
-        $totalItemsQuery = (int) $queryBuilder
+        $totalItems = (int) $queryBuilder
             ->select('SUM(o.itemsTotal) as totalItems')
             ->getQuery()
             ->getSingleScalarResult();
 
-        $totalTaxQuery = (int) $queryBuilder
+        $totalTax = (int) $queryBuilder
             ->select('SUM(adjustment.amount) as totalTaxes')
             ->leftJoin('o.items', 'items')
             ->leftJoin('items.units', 'units')
@@ -81,7 +81,7 @@ private function calculateGmvForPeriodAndCurrency(\DateTimeInterface $periodStar
             ->getQuery()
             ->getSingleScalarResult();
 
-        return $totalItemsQuery - $totalTaxQuery;
+        return $totalItems - $totalTax;
     }
 
     private function createCommonQueryBuilder(\DateTimeInterface $periodStart, \DateTimeInterface $periodEnd): QueryBuilder

tests/Application/config/config.yaml

@@ -22,4 +22,4 @@ framework:
 doctrine:
     dbal:
         driver: pdo_sqlite
-        path: '%kernel.project_dir%/var/data/test.sqlite'
+        path: '%kernel.project_dir%/var/test.sqlite'