Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coding standard #317

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Fix coding standard #317

merged 1 commit into from
Jan 5, 2024

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Jan 2, 2024

No description provided.

@loic425 loic425 force-pushed the fix/coding-standard branch 2 times, most recently from 6c90eb8 to 04b5c87 Compare January 2, 2024 14:12
@loic425 loic425 force-pushed the fix/coding-standard branch from 232b2f9 to 432714c Compare January 2, 2024 14:23
This was referenced Jan 2, 2024
Merged
Merged
@GSadee GSadee merged commit b7f4976 into Sylius:1.12 Jan 5, 2024
7 checks passed
@GSadee
Copy link
Member

GSadee commented Jan 5, 2024

Thank you, Loïc! 🎉

GSadee added a commit that referenced this pull request Jan 5, 2024
@GSadee
minor #315 [Docs] Add info about available form options (loic425)
c9a493e 
This PR was merged into the 1.12 branch.

Discussion
----------

Based on #317 

Commits
-------

6cf5690 [Docs] Add info about available form options on filters
GSadee added a commit that referenced this pull request Jan 5, 2024
@GSadee
bug #316 Don't remove driver options when extending a grid configurat…
3982f7c 
…ion (loic425)

This PR was merged into the 1.12 branch.

Discussion
----------

Based on #317 

```php
<?php

use App\Entity\Suplier;
use Sylius\Bundle\GridBundle\Builder\GridBuilder;
use Sylius\Bundle\GridBundle\Config\GridConfig;

return static function (GridConfig $grid) {
    $grid->addGrid(
        GridBuilder::create('sylius_admin_product_variant')
    );
};

```

When running this following command:
```bash
$ bin/console debug:config sylius_grid grids.sylius_admin_product_variant.driver
```

Before
```yaml
name: doctrine/orm
options: {  }
```

After
```yaml
name: doctrine/orm
options:
    class: App\Entity\Product\ProductVariant
    repository:
        method: createQueryBuilderByProductId
        arguments:
            - "expr:service('sylius.context.locale').getLocaleCode()"
            - $productId
```

Commits
-------

c7d75bd Don't remove driver options when extending a grid configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic425 @GSadee