Add support for Symfony 7 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
symfony-7
branch
2 times, most recently
from
9370c9c to
566b86b
Compare
loic425
force-pushed
the
symfony-7
branch
2 times, most recently
from
7294562 to
28f9d1e
Compare
74 tasks
diimpp
approved these changes
Jun 6, 2024
| name: "PHP ${{ matrix.php }}${{ matrix.symfony != '' && format(', Symfony {0}', matrix.symfony) || '' }}${{ matrix.currency-bundle != '' && format(', CurrencyBundle {0}', matrix.currency-bundle) || '' }}${{ matrix.postgres != '' && format(', PostgresSQL {0}', matrix.postgres) || '' }}" | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php: ["8.0", "8.1"] | ||
| php: ["8.1", "8.2", "8.3"] |
There was a problem hiding this comment.
Since we're allowing installation with PHP 8.0, I think we should leave at least a single build for it.
There was a problem hiding this comment.
I would be for upgrading minimum PHP to 8.1 🤔
There was a problem hiding this comment.
done, I bump php version on Bundle and composer.json
GSadee
reviewed
Sep 4, 2024
| name: "PHP ${{ matrix.php }}${{ matrix.symfony != '' && format(', Symfony {0}', matrix.symfony) || '' }}${{ matrix.currency-bundle != '' && format(', CurrencyBundle {0}', matrix.currency-bundle) || '' }}${{ matrix.postgres != '' && format(', PostgresSQL {0}', matrix.postgres) || '' }}" | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php: ["8.0", "8.1"] | ||
| php: ["8.1", "8.2", "8.3"] |
There was a problem hiding this comment.
I would be for upgrading minimum PHP to 8.1 🤔
.github/workflows/build.yml
Outdated
| @@ -13,23 +13,30 @@ on: | |||
| jobs: | |||
| tests: | |||
| runs-on: ubuntu-latest | |||
| continue-on-error: ${{ matrix.experimental }} | |||
There was a problem hiding this comment.
As we would like to add support for SF7 with this PR, I'm not sure if this flag is needed 🤔
GSadee
approved these changes
Sep 4, 2024
|
Thank you, Loïc! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.