docs: fix a wrong yaml indentation in the reference documentation causing the yaml to be invalid #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkrovitch
changed the title
loic425
requested changes
Dec 14, 2022
loic425
reviewed
Dec 14, 2022
johnkrovitch
force-pushed
the
fix/fix-typo-docs
branch
from
cb734bd to
fb48349
Compare
loic425
requested changes
Jan 9, 2023
|
@johnkrovitch Thanks for your PR, use commit suggestion please. |
|
@johnkrovitch It needs a rebase from 1.10 branch, do you know how to do that? |
|
@loic425 Yes sorry I was quite busy this days.... Yes I will rebase as soon as possible and commit suggestions |
|
@johnkrovitch any update? |
|
@loic425 the pr is rebased, and indentation changes applied |
johnkrovitch
force-pushed
the
fix/fix-typo-docs
branch
2 times, most recently
from
394e714 to
fbd112d
Compare
johnkrovitch
force-pushed
the
fix/fix-typo-docs
branch
from
fbd112d to
5a9eb01
Compare
|
Related to #484 |
lchrusciel
reviewed
Jul 13, 2023
| @@ -12,7 +12,9 @@ sylius_resource: | |||
| repository: ~ | |||
| factory: Sylius\Component\Resource\Factory\Factory | |||
| form: Sylius\Bundle\ResourceBundle\Form\Type\DefaultResourceType | |||
| validation_groups: [sylius] | |||
| #form: | |||
| #options: | |||
There was a problem hiding this comment.
I guess it should rather be something like this:
Suggested change
| #options: | |
| #type: Sylius\Bundle\ResourceBundle\Form\Type\DefaultResourceType | |
| #options: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this pr fixes a wrong yaml indentation in the reference documentation causing the yaml to be invalid.
Thank you very much