Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor expression language #964

Draft
wants to merge 1 commit into
base: 1.13
Choose a base branch
from

Conversation

Florian-Merle
Copy link

@Florian-Merle Florian-Merle commented Dec 13, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Related tickets
License MIT

Since the original services were experimental, I consider that this PR does not introduce any BC breaks.

As discussed with @loic425, this PR aims to port back the changes made in this PR but specifically for the SyliusResourceBundle.

To-do:

  • Update tests
  • cleanup src/Bundle/Resources/config/services/expression_language.xml

@Florian-Merle Florian-Merle changed the title wip Refactor expression language Dec 13, 2024
@Florian-Merle Florian-Merle force-pushed the refactor-expression-language branch from 8ba8b9f to e23d9d4 Compare December 13, 2024 15:34
@Florian-Merle Florian-Merle force-pushed the refactor-expression-language branch from e23d9d4 to f8896b1 Compare December 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant