Improve footer #36
Merged
Improve footer #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellimws
commented
Aug 14, 2020
Comment on lines
+19
to
+20
| copyright = '2020, The SymbiFlow Authors' | ||
| author = 'The SymbiFlow Authors' |
There was a problem hiding this comment.
@mithro Not sure if we can just remove the original author here
|
I just realized that by separating the GitHub link from |
|
@daniellimws This need a rebase so I can merge.... |
* Show underline when hovering over links * Change foreground color to have stronger contrast as per SymbiFlow#7 * Remove extraneous padding and nicely align left side with right side of footer * Add link to LICENSE in GitHub repo Signed-off-by: Daniel Lim Wee Soong <[email protected]>
This allows the GitHub url to be shown in the footer too. Also add a dummy <li> element in the footer so that when there are no links shown, there is still an empty space in that place. Signed-off-by: Daniel Lim Wee Soong <[email protected]>
Signed-off-by: Daniel Lim Wee Soong <[email protected]>
daniellimws
force-pushed
the
license-footer
branch
from
73a8bc3
to
90710a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
header_linksoption so that it can be shown in the footer too