Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Zygote in [weakdeps] to 0.7, (keep existing compat) #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 5, 2025

This pull request changes the compat entry for the Zygote package from 0.6 to 0.6, 0.7.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link
Contributor Author

Benchmark Results

master a67873e... master / a67873e...
eval/ComplexF32/evaluation 7.42 ± 0.59 ms 7.3 ± 0.57 ms 1.02
eval/ComplexF64/evaluation 10.9 ± 1.6 ms 10.9 ± 1.1 ms 1.01
eval/Float32/derivative 13.9 ± 2.5 ms 13.2 ± 1.9 ms 1.05
eval/Float32/derivative_turbo 13.9 ± 2.6 ms 13.2 ± 1.9 ms 1.06
eval/Float32/evaluation 2.83 ± 0.28 ms 2.78 ± 0.26 ms 1.02
eval/Float32/evaluation_bumper 0.627 ± 0.016 ms 0.629 ± 0.016 ms 0.996
eval/Float32/evaluation_turbo 0.607 ± 0.032 ms 0.597 ± 0.032 ms 1.02
eval/Float32/evaluation_turbo_bumper 0.63 ± 0.016 ms 0.632 ± 0.015 ms 0.997
eval/Float64/derivative 17.7 ± 1.2 ms 15.8 ± 1.2 ms 1.12
eval/Float64/derivative_turbo 17.4 ± 0.69 ms 15.5 ± 0.69 ms 1.12
eval/Float64/evaluation 3.27 ± 0.32 ms 3.2 ± 0.32 ms 1.02
eval/Float64/evaluation_bumper 1.29 ± 0.047 ms 1.3 ± 0.049 ms 0.99
eval/Float64/evaluation_turbo 1.15 ± 0.063 ms 1.11 ± 0.059 ms 1.03
eval/Float64/evaluation_turbo_bumper 1.28 ± 0.043 ms 1.29 ± 0.044 ms 0.993
utils/combine_operators/break_sharing 0.0396 ± 0.0013 ms 0.0382 ± 0.00055 ms 1.04
utils/convert/break_sharing 28.4 ± 3.2 μs 27.5 ± 2.8 μs 1.03
utils/convert/preserve_sharing 0.101 ± 0.008 ms 0.0994 ± 0.0057 ms 1.02
utils/copy/break_sharing 28.8 ± 3.7 μs 27.9 ± 2.7 μs 1.04
utils/copy/preserve_sharing 0.101 ± 0.0073 ms 0.1 ± 0.0058 ms 1.01
utils/count_constant_nodes/break_sharing 8.92 ± 0.51 μs 8.59 ± 0.31 μs 1.04
utils/count_constant_nodes/preserve_sharing 0.0913 ± 0.0086 ms 0.0865 ± 0.005 ms 1.05
utils/count_depth/break_sharing 9.25 ± 0.44 μs 9.81 ± 0.3 μs 0.943
utils/count_nodes/break_sharing 9.17 ± 0.46 μs 8.38 ± 0.28 μs 1.09
utils/count_nodes/preserve_sharing 0.0901 ± 0.0089 ms 0.0871 ± 0.0053 ms 1.03
utils/get_set_constants!/break_sharing 0.0341 ± 0.0035 ms 0.0336 ± 0.0025 ms 1.02
utils/get_set_constants!/preserve_sharing 0.178 ± 0.0099 ms 0.175 ± 0.0084 ms 1.02
utils/get_set_constants_parametric 0.0478 ± 0.0036 ms 0.0449 ± 0.0028 ms 1.07
utils/has_constants/break_sharing 4.08 ± 0.29 μs 4.28 ± 0.18 μs 0.953
utils/has_operators/break_sharing 1.94 ± 0.13 μs 2.25 ± 0.1 μs 0.863
utils/hash/break_sharing 24.3 ± 1.4 μs 23 ± 1.2 μs 1.06
utils/hash/preserve_sharing 0.101 ± 0.0091 ms 0.0991 ± 0.0071 ms 1.02
utils/index_constant_nodes/break_sharing 25.8 ± 1.8 μs 25.5 ± 1.3 μs 1.01
utils/index_constant_nodes/preserve_sharing 0.1 ± 0.0053 ms 0.0995 ± 0.0058 ms 1.01
utils/is_constant/break_sharing 4.37 ± 0.31 μs 3.89 ± 0.2 μs 1.12
utils/simplify_tree/break_sharing 0.171 ± 0.0095 ms 0.17 ± 0.0062 ms 1.01
utils/simplify_tree/preserve_sharing 0.225 ± 0.012 ms 0.22 ± 0.0098 ms 1.02
utils/string_tree/break_sharing 0.515 ± 0.033 ms 0.48 ± 0.021 ms 1.07
utils/string_tree/preserve_sharing 0.628 ± 0.041 ms 0.588 ± 0.026 ms 1.07
time_to_load 0.249 ± 0.0088 s 0.22 ± 0.0034 s 1.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant