Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to disable early exit of expression evaluation #91

Merged
merged 44 commits into from
Jul 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
8df4bfe
add early_exit argument
nmheim Jun 30, 2024
8f1d2bd
make tests pass; add first test for early_exit
nmheim Jul 1, 2024
5cbe6a5
bumper & loopvec
nmheim Jul 3, 2024
82c4224
format
nmheim Jul 3, 2024
984a1ba
Merge branch 'SymbolicML:master' into nh/early-exit
nmheim Jul 3, 2024
1ee6884
introduce EvaluationOptions
nmheim Jul 8, 2024
86f8316
Merge branch 'master' into pr/nmheim/91
MilesCranmer Jul 19, 2024
6cab047
style: formatting
MilesCranmer Jul 19, 2024
6d46df9
style: more formatting
MilesCranmer Jul 19, 2024
b8f1087
style: clean up redundant options
MilesCranmer Jul 19, 2024
ee7d7c1
style: rename to `eval_options`
MilesCranmer Jul 19, 2024
c0b5a46
fix: merge edits to eval options
MilesCranmer Jul 19, 2024
17ae595
fix: fix generic eval errors
MilesCranmer Jul 19, 2024
2b98acf
refactor: test_evaluation.jl
MilesCranmer Jul 19, 2024
5399625
fix: specific branch calls
MilesCranmer Jul 19, 2024
204a9df
fix: `v_throw_errors` typo
MilesCranmer Jul 19, 2024
2fc5e87
fix: error catching for generic eval
MilesCranmer Jul 19, 2024
660d6f8
style: rename `EvaluationOptions` to `EvalOptions`
MilesCranmer Jul 19, 2024
dd24df6
test: fix initial errors test
MilesCranmer Jul 19, 2024
6302012
fix: type unstalbe tests
nmheim Jul 22, 2024
a73a04f
add doc strings
nmheim Jul 22, 2024
fe30e8b
update docs
nmheim Jul 22, 2024
944b2e8
format
nmheim Jul 22, 2024
905f5e1
approx equal
nmheim Jul 23, 2024
0a2bb96
fix enzyme test
nmheim Jul 24, 2024
6bd504b
Update docs/src/eval.md
nmheim Jul 25, 2024
54c6398
test: disable enzyme test
MilesCranmer Jul 24, 2024
958b9af
test: skip Enzyme test completely
MilesCranmer Jul 25, 2024
1365a55
test: fix Enzyme test
MilesCranmer Jul 26, 2024
cbcd221
style: fix formatting
MilesCranmer Jul 26, 2024
87c6225
ci: install fixed Enzyme
MilesCranmer Jul 26, 2024
86d2096
fix issue due to https://github.com/JuliaLang/Pkg.jl/issues/1585
MilesCranmer Jul 26, 2024
796cbae
fix custom enzyme install
MilesCranmer Jul 26, 2024
8a1ce63
Merge branch 'master' into nh/early-exit
MilesCranmer Jul 27, 2024
5a30d47
ci: remove Enzyme revision test
MilesCranmer Jul 27, 2024
64c797c
refactor: reduce code complexity of eval options
MilesCranmer Jul 27, 2024
a87016e
docs: render `EvalOptions` in docs
MilesCranmer Jul 27, 2024
ace5c19
test: more coverage of `EvalOptions` branches
MilesCranmer Jul 28, 2024
2c34b4e
test: prevent soft scope problem
MilesCranmer Jul 28, 2024
3113499
refactor: clean up evaluation
MilesCranmer Jul 28, 2024
586baf8
benchmarks: fix benchmark eval options
MilesCranmer Jul 28, 2024
3d7b529
fix: note instability in kw deprecation
MilesCranmer Jul 28, 2024
09b7a3d
feat: also include `early_exit` in scalar checks
MilesCranmer Jul 28, 2024
17a4a24
fix: incorporate `@return_on_nonfinite_val` in LoopVectorization exte…
MilesCranmer Jul 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix issue due to JuliaLang/Pkg.jl#1585
MilesCranmer committed Jul 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 86d209660b6e3785aa695200cddd39968408633e
4 changes: 3 additions & 1 deletion .github/workflows/CI.yml
Original file line number Diff line number Diff line change
@@ -84,7 +84,9 @@ jobs:
- uses: julia-actions/julia-buildpkg@v1
- name: Add fixed version of Enzyme
if: ${{ matrix.test_name == 'enzyme' }}
run: julia --color=yes --project=test/ -e 'import Pkg; Pkg.add(url="https://github.com/EnzymeAD/Enzyme.jl"; rev="ebc27a17dcae0d69f788c1647ef643dbcf20913d")'
run: |
julia --color=yes --project=test/ -e 'import Pkg; Pkg.add(url="https://github.com/EnzymeAD/Enzyme.jl"; rev="ebc27a17dcae0d69f788c1647ef643dbcf20913d")'
julia --color=yes --project=. -e 'import Pkg; Pkg.add(url="https://github.com/EnzymeAD/Enzyme.jl"; rev="ebc27a17dcae0d69f788c1647ef643dbcf20913d")'
- name: Run tests
run: |
julia --color=yes -e 'import Pkg; Pkg.add("Coverage")'