-
Notifications
You must be signed in to change notification settings - Fork 25
Update docs and add doctests #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Hi @abhro, hope you've been well! I love this PR and just wanted to check back in about its current status. I think getting it in would be really helpful for keeping the docs in sync with the |
Hi! I think I've addressed all the changes, it's most likely just the CI checks now |
Oh, could we also add the generated |
Done! |
Sweet, thanks! Have you been able to generate docs with the |
I'm guessing this part is meant for @MilesCranmer? I'm not sure I can offer much help on the deployment side of things |
Sorry, I should have said "because of the Mirror to DAMTP bit" instead of "with the Mirror to DAMTP bit". In other words, this seems like an issue for anyone trying to build the docs locally, so I just wanted to see if we could smooth that process out a bit for folks. Similarly, I was wondering if it might also be good to add a tip about using LiveServer.jl with something like: servedocs(; include_dirs=["src/"], skip_files=["docs/src/index.md"]) so things work well from the jump. Anyway, just wanted to get your perspective to get an idea of if something like this would be helpful or not, haha |
Mmm, yes, that's probably a good idea to add a guard to check if the build is happening in CI or not. |
Please see the commmit messages for relevant changes