Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synocli-file: add pixz #6149

Closed
wants to merge 18 commits into from
Closed

synocli-file: add pixz #6149

wants to merge 18 commits into from

Conversation

dotysan
Copy link
Contributor

@dotysan dotysan commented Jun 16, 2024

Starting over from scratch after I completely bungled #6075.

dotysan and others added 16 commits April 15, 2024 14:05
 - also fix license
 - build from pre-configured tarball instead of raw source
 - which seems to support GNU configure
 - libcrytpo is runtime dependency
 - don't include bsd* cli; just shared object only
 - patched to allow cross-compile
I have no idea why. But spk/synocli-file would not build pixz. However,
cross/libarchive and diyspk/pigz both built standalone just fine.

Also documenting some other strange and no-determininistic artifacts
linked to build enviornment.
Link shared object aliases instead of copy.

Co-authored-by: hgy59 <[email protected]>
 - also clean up kruft
@dotysan dotysan marked this pull request as ready for review June 17, 2024 17:04
@dotysan
Copy link
Contributor Author

dotysan commented Jun 17, 2024

Not sure what I'm doing wrong here. Tried disabling hi3535-6.2.4 with:

UNSUPPORTED_ARCHS = $(ARMv7L_ARCHS)

to no avail.

@dotysan dotysan mentioned this pull request Jun 17, 2024
10 tasks
@hgy59
Copy link
Contributor

hgy59 commented Jun 17, 2024

Not sure what I'm doing wrong here. Tried disabling hi3535-6.2.4 with:

UNSUPPORTED_ARCHS = $(ARMv7L_ARCHS)

to no avail.

don't worry about ARMv7L_ARCHS.
it fails to build cross/fd_8.7.0 due to newer rust version (see #6145).

hgy59 added 2 commits June 18, 2024 00:32
- disable to build tools (we want the library only)
- document the need to build without libiconv
- disable static build and add code optimization to minimize library size
- libarchive builds without native/autoconf
- use configure parameter to avoid the AC_CHECK_FILE patch
- do not disable build for ARMv7L_ARCHS
- update changelog for synocli-file package
@hgy59
Copy link
Contributor

hgy59 commented Jun 17, 2024

@dotysan my review is embedded in the two commits...
A final commit to remove native/autoconf is ready.

Still pending is the question whether we should use a newer code base for pixz, referenced by git commit hash.
If you are ok with the official version 1.0.7, we should remove the commented variant in cross/pixz/Makefile.

(or we can wait for an answer to your question in vasi/pixz#116)

@hgy59
Copy link
Contributor

hgy59 commented Nov 9, 2024

@dotysan I have now merged you PR into #6288.

I don't think we get vasi/pixz#116 answered, so soon an update of synocli-file with your work will be ready.

I took eveyting except the obsolete native/autoconf.

@hgy59 hgy59 closed this in #6288 Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants