Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformers - Update schemas #195

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

marcus-snx
Copy link
Contributor

  • remove fct_core_yield_metrics (model doesn't exist anymore by that name) and replace with fct_token_yields
  • add fct_core_rewards_claimed to Ethereum
  • fix naming for fct_core_rewards_claimed for Base and Arbitrum

Copy link

@frugalchimp frugalchimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so I understand: the code was all correct, we just hadn't changed the table names? And we don't need the exchange_rate for eth because you have hourly_exchange_rate_pnl?

And will this allow the FE to include both claimed and claimable in the PnL calculation?

@marcus-snx
Copy link
Contributor Author

Just so I understand: the code was all correct, we just hadn't changed the table names? And we don't need the exchange_rate for eth because you have hourly_exchange_rate_pnl?

And will this allow the FE to include both claimed and claimable in the PnL calculation?

Ah sorry, I should have clarified. These are all schema changes that don't actually affect the SQL models, they're for testing/documentation. They are used for example when we run dbt test. Also most models have fields we're not necessarily using, but unless they impact performance I think it's fine (like exchange_rate).

@marcus-snx
Copy link
Contributor Author

@frugalchimp let me know if there is any additional feedback for this PR, otherwise I can merge it.

@frugalchimp
Copy link

No extra questions - feel free to merge!

@frugalchimp frugalchimp reopened this Feb 18, 2025
@marcus-snx marcus-snx merged commit d55cbef into main Feb 19, 2025
3 checks passed
@marcus-snx marcus-snx deleted the fix/transformers-marts-schemas-fix branch February 19, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants