-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Various Issues with Lipoic Acid Biosynthesis #830
Conversation
…proteins are strictly mitochondrial
…v were in the BiGG ID column; moved them to the KEGG ID column
… metabolites, stoichiometry, and GPR
…uman proteins are strictly mitochondrial
…their [m] equivalents
…ters from 2Fe2S iron-sulfur clusters
…hey're sorted by the numeric bits of their IDs
…and sulfite by ETHE1
…mitochondria to the cytosol
… reactions not already present
hmm I'm not seeing whatever YAML formatting issue the tests are apparently finding (although it's weird that the "YAML validation" tests passed but the "Test YAML conversion" ones failed; I feel like they usually either both work or both fail, but I'm not sure what the differences between them are) |
…e new metabolite entries
Thanks! will start to review when the new release is published. |
# Conflicts: # model/Human-GEM.yml
…osynth # Conflicts: # model/genes.tsv
getGenesFromGrRules is already in RAVEN
use RAVEN's generic exportForGit instead
…osynth # Conflicts: # data/testResults/README.md # model/genes.tsv
until fully merged in new RAVEN release
The YAML validation error appears to be caused by |
As a tip, you can often quickly find out when specific genes (or other objects) are mentioned in previous issues or PRs, like for But yes, both genes should be removed from |
# Conflicts: # data/testResults/README.md # model/Human-GEM.yml # model/genes.tsv
While running the check tasks locally, I noticed that errors are still being reported. I'm wondering if you directly integrated the |
# Conflicts: # data/testResults/README.md # model/Human-GEM.yml
…osynth # Conflicts: # data/testResults/README.md # model/Human-GEM.yml # model/genes.tsv
# Conflicts: # data/testResults/README.md
yea when I was merging in the latest version of the develop branch, I saw that there was a merge conflict for all rows except the first row in |
It is resolved now. Seems like @JHL-452b approved it earlier already, so I will merge it. |
This PR has been automatically tested with GH Actions. Here is the output of the gene essentiality test: cellLine TP TN FP FN accuracy sensitivity specificity F1 MCC
|
Main improvements in this PR:
As proposed in #685:
MAM02643m
to represent mitochondrial octanoyl-ACPMAM02042m
to represent mitochondrial HS-MAM01098m
to represent mitochondrial 5’-deoxyadenosineMAM20084m
to represent a mitochondrial 4Fe4S iron-sulfur clusterMAM20085m
to represent a mitochondrial 2Fe2S iron-sulfur clusterMAM20086m
to represent mitochondrial GSSHENSG00000100209
, HSCBENSG00000105755
, ETHE1ENSG00000109519
, GRPEL1ENSG00000113013
, HSPA9ENSG00000135070
, ISCA1ENSG00000136003
, ISCU2ENSG00000137714
, FDX1ENSG00000137767
, SQORENSG00000165898
, ISCA2ENSG00000169599
, NFU1ENSG00000181873
, IBA57ENSG00000182512
, GLRX5ENSG00000214113
, LRYM4ENSG00000244005
, NFS1ENSG00000267673
, FDX2MAM00210c
withMAM00210m
,MAM00209c
withMAM00209m
, andMAM00208c
withMAM00208m
in all of the reactions they participate inMAR06404
with their mitochondrial equivalentsENSG00000137767
to the GPR ofMAR06911
MAR06402
toMAM02643m -> MAM00210m + MAM02484m
, GPR:ENSG00000004779 and ENSG00000140905 and ENSG00000175536
, references:PMID:24777537;PMID:28757203
MAR06403
toMAM00210m + 3 MAM02039m + MAM02555m + 2 MAM02877m + MAM20084m --> MAM00208m + 2 MAM01098m + 4 MAM01821m + 2 MAM02042m + 2 MAM02471m + MAM02554m
(ENSG00000121897 and ENSG00000137714 and ENSG00000140905 and ENSG00000161513 and ENSG00000135070 ) or (ENSG00000121897 and ENSG00000137714 and ENSG00000140905 and ENSG00000161513 and ENSG00000165898) or (ENSG00000121897 and ENSG00000137714 and ENSG00000140905 and ENSG00000161513 and ENSG00000169599)
PMID:24777537;PMID:31493409;PMID:36281303;PMID:37453661
MAR20184
to represent synthesis of 4Fe4S iron-sulfur clusters in mitochondria:2 MAM01371m + 2 MAM02040m + MAM02555m + 2 MAM20085m -> 2 MAM01285m + 3 MAM02039m + MAM02554m + 2 MAM02751m + MAM20084m
ENSG00000100209 and ENSG00000109519 and ENSG00000113013 and ENSG00000135070 and ENSG00000161513 and ENSG00000165898 and ENSG00000181873 and ENSG00000182512 and ENSG00000267673
PMID:31918395;PMID:31935115
MAR20185
to represent synthesis of 2Fe2S iron-sulfur clusters in mitochondria:2 MAM01628m + 2 MAM01821m + MAM02555m -> 2 MAM01307m + MAM02039m + MAM02554m + MAM20085m
ENSG00000004779 and ENSG00000136003 and ENSG00000161513 and ENSG00000165060 and ENSG00000214113 and ENSG00000244005 and ENSG00000267673
PMID:31918395;PMID:31935115
MAR20186
to represent the formation of GSSH from GSH and HS- by SQOR:MAM01802m + MAM02026m + MAM02039m + MAM02042m -> MAM01803m + MAM20086m
ENSG00000137767
PMID:25225291
1.8.5.8
, KEGG:R11929
,RHEA:62608
MAR20187
to represent the conversion of GSSH into GSH and sulfite by ETHE1:MAM02040m + MAM02630m + MAM20086m -> MAM02026m + 2 MAM02039m + MAM02949m
ENSG00000105755
PMID:25225291
1.13.11.18
, KEGG:R08678
,RHEA:12981
MAR20188: MAM01098m -> MAM01098c
, references:PMID:34126623
(no GPR)ENSG00000092529
andENSG00000181652
fromgenes.tsv
to fix the YAML validation error that was introduced after they were removed fromHuman-GEM.yml
but notgenes.tsv
in Fix: GPR curation for starch and sucrose metabolism #933 and Fix: GPR curation for subsystems related with amino acid #936I hereby confirm that I have:
develop
as a target branch