Issue #81 No failure during duplicate and write error into event #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomoTsuyuki I know this is a pain, but could you rebase all your code on the 401 and master pull requests? I made the decision to cap the 401 branch to support up to 4.2 and the master branch also supports 4.2 but goes up to Moodle master (currently 4.3+). Thanks! |
TomoTsuyuki
force-pushed
the
issue81-update-mass-duplicate-for-401
branch
from
c351a2b to
6f2d277
Compare
|
Hi @Syxton , I just rebased all PRs with the latest master/MOODLE_401_STABLE branch. Please let me know if you have some feedback/comments. |
TomoTsuyuki
force-pushed
the
issue81-update-mass-duplicate-for-401
branch
from
6f2d277 to
489ff56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #81
Cherry pick from #90