Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): use new backend for orgdiagram for valid results #664

Merged
merged 7 commits into from
May 17, 2020
Merged

fix(backend): use new backend for orgdiagram for valid results #664

merged 7 commits into from
May 17, 2020

Conversation

paule96
Copy link
Collaborator

@paule96 paule96 commented May 1, 2020

No description provided.

@paule96 paule96 requested a review from DanielHabenicht as a code owner May 1, 2020 20:42
@paule96 paule96 added the restyled Label for restyled Pull Requests label May 1, 2020
@paule96 paule96 added this to the New backend for Phonebook milestone May 1, 2020
@mschwrdtnr mschwrdtnr added bug Something isn't working and removed restyled Label for restyled Pull Requests labels May 2, 2020
@paule96
Copy link
Collaborator Author

paule96 commented May 2, 2020

@mschwrdtnr this is more or less a big restyle. :D so maybe the label was good. The result of the restyle is that the bug is fixed yes, but the big thing is that we use the new backend for the organigram. So can I add the label again? :P

@DanielHabenicht
Copy link
Collaborator

Why did this not trigger any build?

@paule96
Copy link
Collaborator Author

paule96 commented May 2, 2020

It does?

image

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-664.demo-phonebook.me

@mschwrdtnr
Copy link
Member

mschwrdtnr commented May 3, 2020 •
edited
Loading

@mschwrdtnr this is more or less a big restyle. :D so maybe the label was good. The result of the restyle is that the bug is fixed yes, but the big thing is that we use the new backend for the organigram. So can I add the label again? :P

For me restyled means something different and also your title says "fix" 🤔

@paule96
Copy link
Collaborator Author

paule96 commented May 3, 2020

Yes because I can't use both. Or can I? Can I do something like: fix(something) feature(something)

So restyle only includes formating?

@mschwrdtnr
Copy link
Member

mschwrdtnr commented May 3, 2020 •
edited
Loading

Yes because I can't use both. Or can I? Can I do something like: fix(something) feature(something)

So restyle only includes formating?

I don't make the rules^^ We should agree on something and write it in our "Contribution Guidelines" @ #412

If it's really just an restyle thing you can use style( ), but I think this is more than style, so maybe chore. Semantic Release is using the Angular commit guidelines

@DanielHabenicht
Copy link
Collaborator

Yes because I can't use both. Or can I? Can I do something like: fix(something) feature(something)

So restyle only includes formating?

why should it be both?
It should be either a fix or a new feature. If it is both it should be two different commits.
restyle on restyles the code. It does not change the functionality.

@DanielHabenicht
Copy link
Collaborator

ready to merge? @paule96

DanielHabenicht
DanielHabenicht previously approved these changes May 8, 2020
View reviewed changes
@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-664.demo-phonebook.me

@DanielHabenicht DanielHabenicht dismissed their stale review May 8, 2020 09:34

error in backend

@DanielHabenicht DanielHabenicht self-requested a review May 8, 2020 09:34
DanielHabenicht
DanielHabenicht requested changes May 8, 2020
View reviewed changes
Copy link
Collaborator

@DanielHabenicht DanielHabenicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Your backend seems to have an error for development

@DanielHabenicht DanielHabenicht mentioned this pull request May 8, 2020
Open
@paule96
Copy link
Collaborator Author

paule96 commented May 16, 2020

Your backend seems to have an error for development

have you an url for me?

@DanielHabenicht
Copy link
Collaborator

/azp run T-Systems-MMS.phonebook-preview

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-664.demo-phonebook.me

@DanielHabenicht
Copy link
Collaborator

@paule96 https://pr-664.demo-phonebook.me/api/OrgUnit

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-664.demo-phonebook.me

@paule96
Copy link
Collaborator Author

paule96 commented May 17, 2020

lol don't has the problem local... what is different in the demo...

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-664.demo-phonebook.me

@DanielHabenicht DanielHabenicht self-requested a review May 17, 2020 19:55
@paule96 paule96 merged commit 73d6ae2 into master May 17, 2020
@mmsgithub-ci
Copy link
Collaborator

🎉 This PR is included in version 1.43.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielHabenicht DanielHabenicht DanielHabenicht approved these changes

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
New backend for Phonebook
Development

Successfully merging this pull request may close these issues.
4 participants
@paule96 @DanielHabenicht @mmsgithub-ci @mschwrdtnr