Added default bangs through URL param with UI to pick default bang #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows mobile user to select a default bang without using dev tools * Keep honoring legacy local-storage * More resilient bang fallback
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
Closes #35 |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| list="bang-list" | ||
| spellcheck="false" | ||
| /> | ||
| <input type="submit" value="Apply" class"bang-confirm"/> |
There was a problem hiding this comment.
There's a syntax error in the class attribute - it's missing an equals sign. The correct syntax should be class="bang-confirm" rather than class"bang-confirm".
Suggested change
| <input type="submit" value="Apply" class"bang-confirm"/> | |
| <input type="submit" value="Apply" class="bang-confirm"/> |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds default bangs in URL params through
default_bang.Why add this PR:
On a more personal note. This is my first PR to a public project. Let me know if anything can be improved!