Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaultProps #10

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Remove defaultProps #10

merged 1 commit into from
Feb 3, 2025
+78 −191

Conversation

nathanfranklin
Copy link
Member

@nathanfranklin nathanfranklin commented Jan 30, 2025 •
edited
Loading

Overview

Refactor to remove defaultProps as they are being deprecated:

Warning: Message: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead

Related

WI-208

…

@nathanfranklin nathanfranklin marked this pull request as draft January 30, 2025 23:00
wesleyboar
wesleyboar approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the commands run successfully. The changes look like an accurate migration.

@wesleyboar wesleyboar self-requested a review January 30, 2025 23:55
@nathanfranklin nathanfranklin marked this pull request as ready for review February 1, 2025 03:57
@wesleyboar wesleyboar merged commit edde99a into main Feb 3, 2025
@wesleyboar wesleyboar deleted the task/remove-default-props branch February 3, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyboar wesleyboar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nathanfranklin @wesleyboar