Skip to content

Conversation

rjgabel
Copy link
Contributor

@rjgabel rjgabel commented Sep 25, 2025

dev build for branch | rjgabel:autoscale-fix

Fix description text not appearing in the Controller/Hotkey configuration menu on some Linux systems. #1430 (comment)

Check if completed:

@YoshiRulz YoshiRulz requested a review from Morilli September 25, 2025 20:59
@YoshiRulz YoshiRulz linked an issue Sep 25, 2025 that may be closed by this pull request
@Morilli
Copy link
Collaborator

Morilli commented Sep 25, 2025

Yeah I don't really want to straight up revert this change because it will regress #4246, but we probably do need to change the autoscale mode in these functions back to Font.

The reason I wanted it to use Dpi is because font scaling is not consistent and usually just depends on the dpi setting again, but it makes sense that things that contain text need to be sized so that the text fits, even if that changes the layout.

@YoshiRulz

This comment was marked as resolved.

@rjgabel

This comment was marked as resolved.

@Morilli
Copy link
Collaborator

Morilli commented Sep 25, 2025

Here's what I would do: Morilli@0726c2d

edit: auto-link assumes this repo, fixed --yoshi

@rjgabel

This comment was marked as resolved.

@YoshiRulz

This comment was marked as resolved.

@rjgabel
Copy link
Contributor Author

rjgabel commented Sep 26, 2025

https://github.com/Morilli/BizHawk/actions/runs/18021719539

Seems like this build fixes the issue.

@YoshiRulz
Copy link
Member

I've tested both that build and this PR, and saw no difference on Ubuntu, while both are still broken on NixOS†.
So @Morilli it's your call on which approach to take.

† So no difference there either.
I did have an idea: You said you use Mint 22? Which would default to an X11 session. My machines run GNOME Wayland and Plasma Wayland respectively, and I suspect the Bazzite user who CNR would also be on Wayland. But then in #4469 OP said she uses Ubuntu 24.04, which I thought would default to Wayland?

@Morilli

This comment was marked as off-topic.

@YoshiRulz

This comment was marked as off-topic.

@rjgabel
Copy link
Contributor Author

rjgabel commented Sep 27, 2025

† So no difference there either. I did have an idea: You said you use Mint 22? Which would default to an X11 session. My machines run GNOME Wayland and Plasma Wayland respectively, and I suspect the Bazzite user who CNR would also be on Wayland. But then in #4469 OP said she uses Ubuntu 24.04, which I thought would default to Wayland?

That's correct, I am using Mint 22. I don't think there's a way for me to switch to Wayland on Mint (at least from the 60 seconds of searching I've done, I'm new to Linux), but if there is I'd be happy to test on Wayland.

Not exactly, the keybinds dialogs are fine

Does this issue happen on 2.11, or is it a regression caused by the fixes? Interestingly, after doing some testing the fix I made seems to actually fix the Memory Editor window as well on my machine (it's broken on 2.10 and 2.11).

Let me know if you want me to close this PR in favor of Morilli's, or integrate their changes into this PR.

@YoshiRulz

This comment was marked as off-topic.

@rjgabel

This comment was marked as off-topic.

@YoshiRulz YoshiRulz added this to the 2.11.1 milestone Oct 9, 2025
@YoshiRulz YoshiRulz added the App: EmuHawk Relating to EmuHawk frontend label Oct 9, 2025
Morilli added a commit that referenced this pull request Oct 9, 2025
and add explicit ScaleDpi functions for code that needs that.

Turns out font scaling is consistent on windows but differs on linux, so this change broke many labels under mono. Using font scaling does make sense when scaling a control specifically to fit text inside of it.

Partially reverts a64d762.

This supersedes #4472 and closes #4469.

Co-Authored-By: Ryan Gabel <[email protected]>
@YoshiRulz YoshiRulz closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: EmuHawk Relating to EmuHawk frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐧] I can't see anything! (Regression)
3 participants