-
Notifications
You must be signed in to change notification settings - Fork 428
fix text not appearing on Linux #4472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yeah I don't really want to straight up revert this change because it will regress #4246, but we probably do need to change the autoscale mode in these functions back to The reason I wanted it to use |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Here's what I would do: Morilli@0726c2d edit: auto-link assumes this repo, fixed --yoshi |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Seems like this build fixes the issue. |
I've tested both that build and this PR, and saw no difference on Ubuntu, while both are still broken on NixOS†. † So no difference there either. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
That's correct, I am using Mint 22. I don't think there's a way for me to switch to Wayland on Mint (at least from the 60 seconds of searching I've done, I'm new to Linux), but if there is I'd be happy to test on Wayland.
Does this issue happen on 2.11, or is it a regression caused by the fixes? Interestingly, after doing some testing the fix I made seems to actually fix the Memory Editor window as well on my machine (it's broken on 2.10 and 2.11). Let me know if you want me to close this PR in favor of Morilli's, or integrate their changes into this PR. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
and add explicit ScaleDpi functions for code that needs that. Turns out font scaling is consistent on windows but differs on linux, so this change broke many labels under mono. Using font scaling does make sense when scaling a control specifically to fit text inside of it. Partially reverts a64d762. This supersedes #4472 and closes #4469. Co-Authored-By: Ryan Gabel <[email protected]>
Fix description text not appearing in the Controller/Hotkey configuration menu on some Linux systems. #1430 (comment)
Check if completed: