Do not default bind two hotkeys to the same key combination. #4485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshiRulz
approved these changes
Oct 5, 2025
| .Where(static info => !info.DisplayName.StartsWith("RA ") && !string.IsNullOrEmpty(info.DefaultBinding)) | ||
| .Select(static info => info.DefaultBinding); | ||
| #pragma warning disable MA0031 // Optimize Enumerable.Count() usage | ||
| Debug.Assert(bindings.Count() == bindings.Distinct().Count(), "Do not default bind multiple hotkeys to the same button combination."); |
There was a problem hiding this comment.
The actual problem here is that this is a double enumeration. Enumerate .ToArray() first.
There was a problem hiding this comment.
What's the double enumeration? I enumerate bindings twice, but doing a ToArray won't change that.
There was a problem hiding this comment.
Looks like the built-in diagnostic for catching those wasn't actually enabled...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.