Add Startslide Scripts #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With linter errors fixed and updated startslides.
malleoz
reviewed
Sep 26, 2023
Gaberboo
reviewed
Sep 26, 2023
Gaberboo
reviewed
Sep 27, 2023
ximk
force-pushed
the
startslide_v2
branch
3 times, most recently
from
98d0729 to
4057e1c
Compare
malleoz
reviewed
Sep 27, 2023
scripts/Startslide_Left.py
Outdated
Comment on lines
42
to
51
| if vehicle in flame_slide_bikes: | ||
| path = os.path.join(path, r"MKW_Inputs", r"Startslides", r"flame_left.csv") | ||
|
|
||
| elif vehicle in spear_slide_bikes: | ||
| path = os.path.join(path, r"MKW_Inputs", r"Startslides", r"spear_left.csv") | ||
|
|
||
| elif vehicle in star_slide_bikes: | ||
| path = os.path.join(path, r"MKW_Inputs", r"Startslides", r"star_left.csv") | ||
|
|
||
| return path |
There was a problem hiding this comment.
Instead of updating path in each of these if-statements, you could just return os.path.join(path ...)
scripts/Startslide_Left.py
Outdated
| path = utils.get_script_dir() | ||
|
|
||
| if vehicle in flame_slide_bikes: | ||
| path = os.path.join(path, r"MKW_Inputs", r"Startslides", r"flame_left.csv") |
There was a problem hiding this comment.
Are these raw strings necessary anymore, since you got rid of the slashes?
There was a problem hiding this comment.
Unsure, this was just what @Gaberboo recommended to me.
|
|
||
| flame_slide_bikes = ("Flame Runner", "Mach Bike", "Sugarscoot", "Zip Zip") | ||
| spear_slide_bikes = ("Jet Bubble", "Phantom", "Spear", "Sneakster", "Wario Bike") | ||
| star_slide_bikes = ("Bit Bike", "Bullet Bike", "Dolphin Dasher", "Magikruiser", |
There was a problem hiding this comment.
Was just curious, is there any performance different using a tuple here instead of a list?
There was a problem hiding this comment.
I doubt the performance is significantly different whether a tuple was used or not, I thought I might as well use one here in case it did.
scripts/Startslide_Right.py
Outdated
Comment on lines
43
to
52
| if vehicle in flame_slide_bikes: | ||
| path = os.path.join(path, r"MKW_Inputs", r"Startslides", r"flame_right.csv") | ||
|
|
||
| elif vehicle in spear_slide_bikes: | ||
| path = os.path.join(path, r"MKW_Inputs", r"Startslides", r"spear_right.csv") | ||
|
|
||
| elif vehicle in star_slide_bikes: | ||
| path = os.path.join(path, r"MKW_Inputs", r"Startslides", r"star_right.csv") | ||
|
|
||
| return path |
- Fixed module import with integration of TASLabz/dolphin@61f6735 - Removed unnecessary memory checks - Updated TTK call to reflect new version - Removed unnecessary `global playerInputs` call - Fixed linter errors - Use `os.path.join()` to retrieve path - More linter error fixes - Removed path separators - Final fixes after review
malleoz
approved these changes
Sep 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds startslide functionality using
.csvfiles.